Fix for Issue #123 #178
Merged
Fix for Issue #123 #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update torch_wrapper.py
|
@theperiperi Hi! Thanks for your excellent suggestions! Please check my comments. |
|
I don't see any comments, where do I check them? |
Koukyosyumei
requested changes
Apr 15, 2024
| @@ -21,9 +21,9 @@ class PaillierTensor(object): | |||
| """torch.Tensor-like object for Paillier Encryption""" | |||
|
|
|||
| def __init__(self, paillier_array): | |||
| if type(paillier_array) == list: | |||
| if isinstance(paillier_array) == list: | |||
There was a problem hiding this comment.
Is it a typo of isinstance(paillier_array, list)?
| self._paillier_np_array = np.array(paillier_array) | ||
| elif type(paillier_array) == np.ndarray: | ||
| elif isinstance(paillier_array) == np.ndarray: |
There was a problem hiding this comment.
Is it a typo of isinstance(paillier_array, np.ndarray)?
|
I'm sorry I forgot making my comments public. I think now you can see my comments. |
Koukyosyumei
requested changes
Apr 15, 2024
There was a problem hiding this comment.
You are almost there!! Please check the document of isinstance. https://docs.python.org/3/library/functions.html#isinstance
|
Rookie mistake, sorry about that, I think that fixes it |
Koukyosyumei
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed type() to isinstance() for typechecks in src/aijack/defense/paillier/torch_wrapper.py