-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Issue #123 #178
Merged
+2
−2
Merged
Fix for Issue #123 #178
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2545497
Update torch_wrapper.py
theperiperi 3d13ad9
Merge pull request #1 from theperiperi/theperiperi-patch-1
theperiperi 23d5958
Merge pull request #2 from Koukyosyumei/main
theperiperi 1bab2a7
Update torch_wrapper.py
theperiperi 1228f3b
Update torch_wrapper.py
theperiperi b8c3386
remove redundant comparisons
Koukyosyumei File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,9 +21,9 @@ class PaillierTensor(object): | |
"""torch.Tensor-like object for Paillier Encryption""" | ||
|
||
def __init__(self, paillier_array): | ||
if type(paillier_array) == list: | ||
if isinstance(paillier_array) == list: | ||
self._paillier_np_array = np.array(paillier_array) | ||
elif type(paillier_array) == np.ndarray: | ||
elif isinstance(paillier_array) == np.ndarray: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it a typo of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes, fixed it |
||
self._paillier_np_array = paillier_array | ||
else: | ||
raise TypeError(f"{type(paillier_array)} is not supported.") | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it a typo of
isinstance(paillier_array, list)
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes,fixed it