Fixes for multifilesystem backend #215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required as we do not want .props files to be created for nodes, otherwise they'll stop being considered as nodes, which will break discovery of calendars. This fixes Kozea#208
We also don't need the write method anymore.
It must do nothing here, instead of inheriting the filesystem behavior.
Just to make it easier to know what is overridden, when comparing to parent classes.
This matters, especially for removed files.
|
Apart from the mentioned issue, this seems to work well (rebased on master and with #236 applied) |
|
Can anybody interested merge master in this branch and try to solve the collection discovery? |
|
Changed made for #372 make this PR obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this contains #209 and #211