Improve Git commit behavior on replace() #183
Closed
+23
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement replace() instead of composing remove() and append(), so that it performs not two independent but a single, concise transaction on the storage backend. This is generally more efficient and especially desirable when Git support is enabled. This change also adds slightly more informative commit messages.
|
Concise, neat, perfect. Thanks! |
|
Can you also update the mutlifilesystem backend? |
|
I would, but I'm not entirely sure how the multifilesystem backend is supposed to work, since it doesn't for me. There's already an open bug for this: #150 |
|
@dnnr I've added commits for this in https://github.com/vuntz/Radicale/commits/multifilesystem-fixes-git ; however, you can't just cherry-pick them as they depend on my changes at #215 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement replace() instead of composing remove() and append(), so that
it performs not two independent but a single, concise transaction on the
storage backend. This is generally more efficient and especially
desirable when Git support is enabled.
This change also adds slightly more informative commit messages.