Improve Git commits #286
Closed
Improve Git commits #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement replace() instead of composing remove() and append(), so that it performs not two independent but a single, concise transaction on the storage backend. This is generally more efficient and especially desirable when Git support is enabled. This change also adds slightly more informative commit messages.
This minimizes the difference committed to the backend by preventing arbitrary reordering of unchanged lines.
Sorting now preserves the positions of all BEGIN: and END: lines to reflect the fact that items can be nested.
This ensures that joint items are properly sorted during parsing, since sorting them is not possible anymore when serializing the entire collection.
|
Git support has been removed from Radicale and will be possible using external tools (see #372). Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a resurrection and extension of the outdated #183.
It changes replace() to be actually implemented instead of composing remove() and append(), so that it performs not two independent but a single, concise transaction on the storage backend. This is generally more efficient and especially desirable when Git support is enabled.
It also makes the commit messages slightly more informative and reduces the amount of changes in each commit by sorting fields and removing PRODID beforehand.