Add :global_name for Nostrum.Struct.User

[Ovyerus]

Ref: discord/discord-api-docs#6130

Adds :global_name to the user struct to support the new username & display name/"pomelo" system for Discord.

Also updates User.full_name/1 to show only the global name if present (otherwise falling back to the old Username#1234), and User.avatar_url/1 to use the new method of calculating the default avatar URL for a user if their discriminator is missing (ie. "0") (reference: https://github.com/discord/discord-api-docs/blob/b7a4d80861aea9e116d123a253acd460386a89b5/docs/Change_Log.md?plain=1#L45-L47)

iex(2)> alias Nostrum.Struct.User
Nostrum.Struct.User
iex(3)> User.full_name(%User{global_name: "Rie", username: "rie_t", discriminator: "0"})
"Rie"
iex(4)> User.full_name(%User{global_name: nil, username: "Ovyerus", discriminator: "2211"})
"Ovyerus#2211"

[jchristgit]

Thank you!

I will merge this if Discord decides to go forward with the change, given the upstream docs change is not fully merged yet, a part of me is still hoping they don't decide on implementing it after all. Let's see what happens.

[chimpdev]

Thank you!

I will merge this if Discord decides to go forward with the change, given the upstream docs change is not fully merged yet, a part of me is still hoping they don't decide on implementing it after all. Let's see what happens.

They will not stop what they are doing.

[bdanklin]

Thank you!
I will merge this if Discord decides to go forward with the change, given the upstream docs change is not fully merged yet, a part of me is still hoping they don't decide on implementing it after all. Let's see what happens.

They will not stop what they are doing.

just like they didn't stop their plans for using discord as a game distribution platform..... oh wait

[Ovyerus]

Looks like the API changes got moved to discord/discord-api-docs#6218 which has since been merged.

(Had to update to avatar calculation since users in the new system get a new pink avatar, dunno what happened with the commit history in here, thanks GitHub)

[jchristgit]

Looks like the API changes got moved to discord/discord-api-docs#6218 which has since been merged.

(Had to update to avatar calculation since users in the new system get a new pink avatar, dunno what happened with the commit history in here, thanks GitHub)

Fair enough. Then I think we can merge it. But I need a clean history. Can you try a rebase or should I try on a separate branch?

[Ovyerus]

I'll try a rebase

[Ovyerus]

Ok should be good now, I did do a rebase last time but I'm not sure what goofed up.

[jchristgit]

Thanks!

[jchristgit]

       "https://cdn.discordapp.com/embed/avatars/5.png"
     code:  Nostrum.Struct.User.avatar_url(user) === "https://cdn.discordapp.com/embed/avatars/5.png"
     left:  "https://cdn.discordapp.com/embed/avatars/4.png"
     right: "https://cdn.discordapp.com/embed/avatars/5.png"
     stacktrace:

Is this test failure due to the pink avatar changes?

[Ovyerus]

I think so yea. Also looks like the last 2 commits from the rebase are screwed up for some reason. Will fix!

Looks like it was just those weird commits causing it.

[jchristgit]

Thanks!

[jchristgit]

Thanks!