Start username docs updates #6130

shaydewael · 2023-05-04T17:35:57Z

Update docs based on the new username changes (outlined here for regular users and here for apps/bots)

docs/Reference.md

advaith1 · 2023-05-04T19:40:30Z

docs/Change_Log.md

+
+The new username system will rollout to users over time rather than all at once. The value of a single zero (`"0"`) in the [`discriminator` field](#DOCS_RESOURCES_USER/user-object-user-structure) on a user will indicate that the user has been migrated to the new username system. Note that the discriminator for migrated users will *not* be 4-digits like a standard discriminator (it is `"0"`, not `"0000"`). The value of the `username` field will become the migrated user's unique username.
+
+After migration of all users is complete, the `discriminator` field may be removed.


Suggested change

After migration of all users is complete, the `discriminator` field may be removed.

After migration of all users is complete, the `discriminator` field may be removed in a future API version.

docs/Change_Log.md

Syjalo · 2023-05-04T23:20:36Z

docs/Reference.md

@@ -318,7 +318,7 @@ Discord uses ids and hashes to render images in the client. These hashes can be
 | Guild Discovery Splash      | discovery-splashes/[guild_id](#DOCS_RESOURCES_GUILD/guild-object)/[guild_discovery_splash](#DOCS_RESOURCES_GUILD/guild-object).png                                                                                                                                | PNG, JPEG, WebP      |
 | Guild Banner                | banners/[guild_id](#DOCS_RESOURCES_GUILD/guild-object)/[guild_banner](#DOCS_RESOURCES_GUILD/guild-object).png \*                                                                                                                                                  | PNG, JPEG, WebP, GIF |
 | User Banner                 | banners/[user_id](#DOCS_RESOURCES_USER/user-object)/[user_banner](#DOCS_RESOURCES_USER/user-object).png \*                                                                                                                                                        | PNG, JPEG, WebP, GIF |
-| Default User Avatar         | embed/avatars/[user_discriminator](#DOCS_RESOURCES_USER/user-object).png \*\* \*\*\*                                                                                                                                                                              | PNG                  |
+| Default User Avatar         | embed/avatars/[user_id](#DOCS_RESOURCES_USER/user-object).png \*\* \*\*\*                                                                                                                                                                              | PNG                  |


This is not an API route, but CDN

user_id is correct
with user_discriminator the calculation was user_discriminator % 5 as well

The problem here is that this is listed as user_id even though it is computed to be (user_id >> 22) % 5 but it is listed away as a note for some reason, and that reason is very likely "I couldn't find a better name for it." Just wish it was in here instead as at a glance it is inaccurate unless you read its disclaimer.

Fair. Maybe a new section could be added for this docs part and be linked in this table like calculated_hash

And in the section the calculation method then.

discord/discord-api-docs#6130

docs/Change_Log.md

Syjalo · 2023-05-05T12:03:45Z

docs/resources/User.md

@@ -28,7 +28,8 @@ There are other rules and restrictions not shared here for the sake of spam and
 | ------------- | --------- | ---------------------------------------------------------------------------------------------------- | --------------------- |
 | id            | snowflake | the user's id                                                                                        | identify              |
 | username      | string    | the user's username, not unique across the platform                                                  | identify              |
-| discriminator | string    | the user's 4-digit discord-tag                                                                       | identify              |
+| discriminator | string    | the user's Discord-tag                                                                               | identify              |
+| global_name   | ?string   | the user's display name, if it is set. For bots, this is the application name                        | identify              |


Is the property nullable just during the migration or an user may not has a global name even after the migration?

As part of the new username system, standard Discord users can define a non-unique display name. This value will be a new global_name field with a max length of 32 characters. If the user has not set a display name, global_name will be null.

discord-api-docs/docs/Change_Log.md

Line 41 in b7a4d80

As part of the new username system, standard Discord users can define a non-unique display name. This value will be a new `global_name` field with a max length of 32 characters. If the user has not set a display name, `global_name` will be null.

lukellmann · 2023-05-05T15:50:11Z

docs/resources/User.md

@@ -28,7 +28,8 @@ There are other rules and restrictions not shared here for the sake of spam and
 | ------------- | --------- | ---------------------------------------------------------------------------------------------------- | --------------------- |
 | id            | snowflake | the user's id                                                                                        | identify              |
 | username      | string    | the user's username, not unique across the platform                                                  | identify              |
-| discriminator | string    | the user's 4-digit discord-tag                                                                       | identify              |
+| discriminator | string    | the user's Discord-tag                                                                               | identify              |
+| global_name   | ?string   | the user's display name, if it is set. For bots, this is the application name                        | identify              |


see discord/discord-api-docs#6130

* fix: correct typehint for discrim * fix💥: account for discord's discrim change * fix: match behavior to discord docs pr discord/discord-api-docs#6130 * feat: set default for discrim --------- Co-authored-by: Astrea49 <25420078+Astrea49@users.noreply.github.com>

Doc94 · 2023-05-16T23:43:00Z

looks like they add a new field called display_name not?

advaith1 · 2023-05-16T23:52:42Z

display_name is deprecated, it was replaced with global_name

Co-authored-by: Florian Spieß <business@minn.dev>

Co-authored-by: Néstor Pérez <25409753+prryplatypus@users.noreply.github.com>

Co-authored-by: Suspense <64612795+AlmostSuspense@users.noreply.github.com>

AwesomeStickz · 2023-05-17T16:36:21Z

docs/resources/User.md

@@ -28,7 +28,8 @@ There are other rules and restrictions not shared here for the sake of spam and
 | ------------- | --------- | ---------------------------------------------------------------------------------------------------- | --------------------- |
 | id            | snowflake | the user's id                                                                                        | identify              |
 | username      | string    | the user's username, not unique across the platform                                                  | identify              |


devsnek · 2023-05-18T19:16:07Z

docs/Reference.md

@@ -318,7 +318,7 @@ Discord uses ids and hashes to render images in the client. These hashes can be
 | Guild Discovery Splash      | discovery-splashes/[guild_id](#DOCS_RESOURCES_GUILD/guild-object)/[guild_discovery_splash](#DOCS_RESOURCES_GUILD/guild-object).png                                                                                                                                | PNG, JPEG, WebP      |
 | Guild Banner                | banners/[guild_id](#DOCS_RESOURCES_GUILD/guild-object)/[guild_banner](#DOCS_RESOURCES_GUILD/guild-object).png \*                                                                                                                                                  | PNG, JPEG, WebP, GIF |
 | User Banner                 | banners/[user_id](#DOCS_RESOURCES_USER/user-object)/[user_banner](#DOCS_RESOURCES_USER/user-object).png \*                                                                                                                                                        | PNG, JPEG, WebP, GIF |
-| Default User Avatar         | embed/avatars/[user_discriminator](#DOCS_RESOURCES_USER/user-object).png \*\* \*\*\*                                                                                                                                                                              | PNG                  |
+| Default User Avatar         | embed/avatars/[user_id](#DOCS_RESOURCES_USER/user-object).png \*\* \*\*\*                                                                                                                                                                              | PNG                  |


i'd just call it index, and then have instructions below for how to calculate it.

A5rocks · 2023-05-22T00:14:35Z

Hi, is the default avatar changing for all users or just those with this new username system? This PR seems to contradict itself on this and I didn't get a response in DDevs :(

Lulalaby · 2023-05-22T01:46:31Z

Hi, is the default avatar changing for all users or just those with this new username system? This PR seems to contradict itself on this and I didn't get a response in DDevs :(

for the ones with the new username.
if you try the way for ones with discrim, the generated avatar differs from the one in the client.

so if user has discrim: discrim % 5
if user has new username: (id >> 22) % 6

valdotle · 2023-05-26T12:18:44Z

docs/Change_Log.md

+#### May 3, 2023
+
+## Unique usernames on Discord


Suggested change

#### May 3, 2023

## Unique usernames on Discord

## Unique usernames on Discord

#### May 3, 2023

Fix formatting in accordance with #6162.

ImRodry · 2023-06-04T01:16:29Z

Will the display_name property also be documented? Seems to do the same as global_name, idk why it's there

advaith1 · 2023-06-04T01:23:34Z

display_name was renamed to global_name, ignore the old one

FasterSpeeding · 2023-06-05T18:20:34Z

has this PR been abandoned?

docs/Change_Log.md

shaydewael · 2023-06-07T16:45:15Z

moved to #6218 because of some weird syncing issues

RGBCube · 2023-06-09T17:08:12Z

Hi, is the default avatar changing for all users or just those with this new username system? This PR seems to contradict itself on this and I didn't get a response in DDevs :(

for the ones with the new username.
if you try the way for ones with discrim, the generated avatar differs from the one in the client.

so if user has discrim: discrim % 5
if user has new username: (id >> 22) % 5

Now it is (id >> 22) % 6 because of the new pink default profile picture

Lulalaby · 2023-06-09T17:49:54Z

Updated my comment 👌

start username docs

a768ffc

shaydewael requested a review from devsnek May 4, 2023 17:36

Lulalaby mentioned this pull request May 4, 2023

feat!: pomelo Pycord-Development/pycord#2042

Merged

default avatar

9a162cf

MinnDevelopment reviewed May 4, 2023

View reviewed changes

docs/Reference.md Outdated Show resolved Hide resolved

MinnDevelopment mentioned this pull request May 4, 2023

Start migration to new username API discord-jda/JDA#2462

Merged

6 tasks

advaith1 reviewed May 4, 2023

View reviewed changes

prryplatypus reviewed May 4, 2023

View reviewed changes

docs/Change_Log.md Outdated Show resolved Hide resolved

Syjalo mentioned this pull request May 4, 2023

feat: support new username system discordjs/discord.js#9512

Merged

VelvetToroyashi mentioned this pull request May 4, 2023

Add pomelo support (@username) Remora/Remora.Discord#303

Merged

TTtie mentioned this pull request May 4, 2023

feat: unique username system support projectdysnomia/dysnomia#70

Merged

N1ckPro mentioned this pull request May 4, 2023

feat: support new username system discordjs/discord-api-types#765

Merged

Syjalo reviewed May 4, 2023

View reviewed changes

AstreaTSS added a commit to AstreaTSS/interactions-py-library that referenced this pull request May 4, 2023

fix: match behavior to discord docs pr

ef6ca61

discord/discord-api-docs#6130

AstreaTSS mentioned this pull request May 4, 2023

fix: account for discord's discrim change interactions-py/interactions.py#1384

Merged

13 tasks

AlmostSuspense reviewed May 5, 2023

View reviewed changes

docs/Change_Log.md Outdated Show resolved Hide resolved

Syjalo reviewed May 5, 2023

View reviewed changes

lukellmann reviewed May 5, 2023

View reviewed changes

lukellmann added a commit to kordlib/kord that referenced this pull request May 5, 2023

Support new username system

a5469a2

see discord/discord-api-docs#6130

lukellmann mentioned this pull request May 5, 2023

Support new username system kordlib/kord#825

Merged

This was referenced May 5, 2023

Add support for the new username system Discord4J/discord-json#147

Merged

Add support for the new username system Discord4J/Discord4J#1147

Merged

Snazzah mentioned this pull request May 6, 2023

feat: support new username system Snazzah/slash-create#470

Merged

Puyodead1 mentioned this pull request May 6, 2023

Implement Pomelo spacebarchat/server#1049

Draft

4 tasks

erkinalp mentioned this pull request May 6, 2023

Username system changes on the Discord-side matrix-org/matrix-appservice-discord#884

Open

shiftinv mentioned this pull request May 6, 2023

feat: support new username system DisnakeDev/disnake#1025

Merged

13 tasks

Syjalo mentioned this pull request May 6, 2023

feat(Discord): support new username system nextauthjs/next-auth#7464

Closed

3 tasks

AwesomeStickz mentioned this pull request May 17, 2023

feat: add support for new username system discordeno/discordeno#3035

Merged

seailz mentioned this pull request May 17, 2023

feat(usernames): pomelo (new username system) discord-jar/discord.jar#174

Merged

4 tasks

shaydewael and others added 3 commits May 17, 2023 15:24

Update docs/Reference.md

551843e

Co-authored-by: Florian Spieß <business@minn.dev>

Update docs/Change_Log.md

090d609

Co-authored-by: Néstor Pérez <25409753+prryplatypus@users.noreply.github.com>

Update docs/Change_Log.md

b7a4d80

Co-authored-by: Suspense <64612795+AlmostSuspense@users.noreply.github.com>

ghost mentioned this pull request May 18, 2023

feat(User): add globalName property Swishilicous/discord-types#2

Merged

AwesomeStickz reviewed May 18, 2023

View reviewed changes

devsnek reviewed May 18, 2023

View reviewed changes

Ovyerus mentioned this pull request May 21, 2023

Add :global_name for Nostrum.Struct.User Kraigie/nostrum#491

Merged

A5rocks mentioned this pull request May 22, 2023

Migrate to new username system OceanicJS/Oceanic#66

Merged

MahdiBM added a commit to DiscordBM/DiscordBM that referenced this pull request May 22, 2023

Add the new global_name User objects discord/discord-api-docs#6130

a915d13

NeloBlivion mentioned this pull request May 23, 2023

fix: Adjust default_avatar behavior depending on username Pycord-Development/pycord#2087

Merged

9 tasks

Dakurei mentioned this pull request May 24, 2023

New usernames system shardlab/discordrb#221

Merged

valdotle reviewed May 26, 2023

View reviewed changes

onerandomusername reviewed Jun 6, 2023

View reviewed changes

docs/Change_Log.md Show resolved Hide resolved

starshine-sys mentioned this pull request Jun 6, 2023

Add support for the new username system diamondburned/arikawa#393

Merged

shaydewael marked this pull request as ready for review June 7, 2023 16:41

shaydewael closed this Jun 7, 2023

shaydewael mentioned this pull request Jun 7, 2023

Username Docs Updates #6218

Merged

spifory mentioned this pull request Jun 8, 2023

feat: implement new username system nextcord/nextcord#1061

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Start username docs updates #6130

Start username docs updates #6130

shaydewael commented May 4, 2023 •

edited

Loading

advaith1 May 4, 2023

Syjalo May 4, 2023 •

edited

Loading

Syjalo May 5, 2023

Lulalaby May 5, 2023

Jiralite May 5, 2023

Lulalaby May 5, 2023

Syjalo May 5, 2023 •

edited

Loading

kkrypt0nn May 23, 2023

lukellmann May 5, 2023 •

edited

Loading

Doc94 commented May 16, 2023

advaith1 commented May 16, 2023

AwesomeStickz May 17, 2023

devsnek May 18, 2023

A5rocks commented May 22, 2023

Lulalaby commented May 22, 2023 •

edited

Loading

valdotle May 26, 2023

ImRodry commented Jun 4, 2023

advaith1 commented Jun 4, 2023

FasterSpeeding commented Jun 5, 2023

shaydewael commented Jun 7, 2023

RGBCube commented Jun 9, 2023

Lulalaby commented Jun 9, 2023


		The new username system will rollout to users over time rather than all at once. The value of a single zero (`"0"`) in the [`discriminator` field](#DOCS_RESOURCES_USER/user-object-user-structure) on a user will indicate that the user has been migrated to the new username system. Note that the discriminator for migrated users will not be 4-digits like a standard discriminator (it is `"0"`, not `"0000"`). The value of the `username` field will become the migrated user's unique username.

		After migration of all users is complete, the `discriminator` field may be removed.

	\| Default User Avatar \| embed/avatars/[user_id](#DOCS_RESOURCES_USER/user-object).png \\ \\\* \| PNG \|
	\| Default User Avatar \| embed/avatars/[user_creation_timestamp](#DOCS_RESOURCES_USER/user-object).png \\ \\\* \| PNG \|

	\| global_name \| ?string \| the user's display name, if it is set. For bots, this is the application name \| identify \|
	\| global_name? \| ?string \| the user's display name, if it is set. For bots, this is the application name \| identify \|

	\| username \| string \| the user's username, not unique across the platform \| identify \|
	\| username \| string \| the user's username, unique across the platform \| identify \|

Start username docs updates #6130

Start username docs updates #6130

Conversation

shaydewael commented May 4, 2023 • edited Loading

Choose a reason for hiding this comment

Syjalo May 4, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Syjalo May 5, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lukellmann May 5, 2023 • edited Loading

Choose a reason for hiding this comment

Doc94 commented May 16, 2023

advaith1 commented May 16, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

A5rocks commented May 22, 2023

Lulalaby commented May 22, 2023 • edited Loading

Choose a reason for hiding this comment

ImRodry commented Jun 4, 2023

advaith1 commented Jun 4, 2023

FasterSpeeding commented Jun 5, 2023

shaydewael commented Jun 7, 2023

RGBCube commented Jun 9, 2023

Lulalaby commented Jun 9, 2023

shaydewael commented May 4, 2023 •

edited

Loading

Syjalo May 4, 2023 •

edited

Loading

Syjalo May 5, 2023 •

edited

Loading

lukellmann May 5, 2023 •

edited

Loading

Lulalaby commented May 22, 2023 •

edited

Loading