Skip to content

Commit

Permalink
chore: optimize some err messages (#1141)
Browse files Browse the repository at this point in the history
  • Loading branch information
SparkYuan committed Jun 3, 2024
1 parent 036e44a commit f258f51
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion pkg/engine/release/util.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ func NewApplyRelease(storage Storage, project, stack, workspace string) (*v1.Rel
return nil, err
}
if lastRelease.Phase != v1.ReleasePhaseSucceeded && lastRelease.Phase != v1.ReleasePhaseFailed {
return nil, fmt.Errorf("cannot new release of project %s, workspace %s cause there is release in progress", project, workspace)
return nil, fmt.Errorf("cannot create a new release of project: %s, workspace: %s. There is a release:%v in progress",
project, workspace, lastRelease.Revision)
}
if err != nil {
return nil, err
Expand Down
2 changes: 1 addition & 1 deletion pkg/modules/generators/app_configurations_generator.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ func NewAppConfigurationGenerator(
}

if err := workspace.ValidateWorkspace(ws); err != nil {
return nil, fmt.Errorf("invalid config of workspace %s, %w", ws.Name, err)
return nil, fmt.Errorf("invalid config of workspace: %s, %w", ws.Name, err)
}

return &appConfigurationGenerator{
Expand Down

0 comments on commit f258f51

Please sign in to comment.