New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: optimize some err messages #1141

Merged

liu-hm19 merged 1 commit into KusionStack:main from SparkYuan:chore-msg

Jun 3, 2024

Member

SparkYuan commented May 31, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., design docs, usage docs, etc.:


          chore: optimize some err messages

bd52c8f

coveralls commented May 31, 2024

Pull Request Test Coverage Report for Build 9321027294

Details

0 of 3 (0.0%) changed or added relevant lines in 2 files are covered.
7 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.05%) to 54.307%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/modules/generators/app_configurations_generator.go	0	1	0.0%
pkg/engine/release/util.go	0	2	0.0%

Files with Coverage Reduction	New Missed Lines	%
pkg/cmd/apply/apply.go	7	48.08%

Totals
Change from base Build 9284547619:	-0.05%
Covered Lines:	8876
Relevant Lines:	16344

💛 - Coveralls

liu-hm19 approved these changes

View reviewed changes

Contributor

liu-hm19 left a comment

lgtm

liu-hm19 merged commit f258f51 into KusionStack:main

6 checks passed

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.