Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply supports port forwarding #1057

Merged

Conversation

liu-hm19
Copy link
Contributor

@liu-hm19 liu-hm19 commented Apr 19, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR supports the port-forwarding for kusion apply.

Which issue(s) this PR fixes:

Fixes #1017

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@coveralls
Copy link

coveralls commented Apr 19, 2024

Pull Request Test Coverage Report for Build 8781567754

Details

  • 36 of 160 (22.5%) changed or added relevant lines in 2 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 54.908%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/apply/apply.go 0 26 0.0%
pkg/engine/operation/port_forward.go 36 134 26.87%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 79.27%
pkg/cmd/apply/apply.go 3 50.51%
Totals Coverage Status
Change from base Build 8780720615: -0.2%
Covered Lines: 8794
Relevant Lines: 16016

💛 - Coveralls

pkg/cmd/apply/apply.go Outdated Show resolved Hide resolved
@liu-hm19 liu-hm19 force-pushed the support-port-forward-and-browser branch from 55a896b to f07b8d7 Compare April 22, 2024 08:54
@liu-hm19 liu-hm19 force-pushed the support-port-forward-and-browser branch from f07b8d7 to 1de2132 Compare April 22, 2024 09:15
@liu-hm19 liu-hm19 changed the title feat: support port forwarding and browser opening for kusion apply feat: apply supports port forwarding Apr 22, 2024
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit cbd6cfd into KusionStack:main Apr 22, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: kusion apply supports application connection validation
3 participants