New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set release phase to failed if ctrl+C #1137

Closed

healthjyk wants to merge 1 commit into KusionStack:main from healthjyk:handle-ctrlc

Contributor

healthjyk commented May 28, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., design docs, usage docs, etc.:


          feat: set release phase to failed if ctrl+C

de51a30

healthjyk requested a review from liu-hm19

May 28, 2024 12:37

coveralls commented May 28, 2024

Pull Request Test Coverage Report for Build 9269441457

Details

52 of 87 (59.77%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 54.367%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/util/signal/signal.go	17	24	70.83%
pkg/cmd/apply/apply.go	26	34	76.47%
pkg/cmd/destroy/destroy.go	9	29	31.03%

Totals
Change from base Build 9265142956:	0.02%
Covered Lines:	8857
Relevant Lines:	16291

💛 - Coveralls

Contributor

liu-hm19 commented Jun 4, 2024

Due to the lint errors and some conflicts with the latest commit, I have made the code modifications into the PR of #1139 and closed this PR for now.

liu-hm19 closed this

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.