Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize kusion apply with by default watching #1139

Merged
merged 4 commits into from
Jun 4, 2024

Conversation

liu-hm19
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR refines the kusion apply cmd with augmented watch ability and a better terminal display.
kusion apply now will by default check whether the resource is reconciled while applying and support setting the timeout flag.

Which issue(s) this PR fixes:

Fixes #1115 and #1116

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@liu-hm19 liu-hm19 requested a review from SparkYuan May 30, 2024 08:23
@liu-hm19 liu-hm19 self-assigned this May 30, 2024
@liu-hm19 liu-hm19 added the kind/feature Categorizes issue or PR as related to a new feature label May 30, 2024
@liu-hm19 liu-hm19 added this to the v0.12.0 milestone May 30, 2024
@coveralls
Copy link

coveralls commented May 30, 2024

Pull Request Test Coverage Report for Build 9363437442

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 267 of 532 (50.19%) changed or added relevant lines in 10 files are covered.
  • 11 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.001%) to 54.355%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/engine/release/util.go 0 7 0.0%
pkg/util/signal/signal.go 17 24 70.83%
pkg/server/manager/stack/stack_manager.go 0 9 0.0%
pkg/engine/runtime/kubernetes/kubernetes_runtime.go 0 22 0.0%
pkg/engine/runtime/terraform/terraform_runtime.go 11 64 17.19%
pkg/cmd/apply/apply.go 224 391 57.29%
Files with Coverage Reduction New Missed Lines %
pkg/server/manager/stack/stack_manager.go 1 19.42%
pkg/cmd/apply/apply.go 1 51.9%
pkg/engine/release/util.go 9 7.34%
Totals Coverage Status
Change from base Build 9284547619: 0.001%
Covered Lines: 9098
Relevant Lines: 16738

💛 - Coveralls

@liu-hm19 liu-hm19 changed the title feat: refine kusion apply with watch feat: optimize kusion apply with by default watching May 30, 2024
pkg/cmd/apply/apply.go Outdated Show resolved Hide resolved
pkg/cmd/apply/apply.go Show resolved Hide resolved
pkg/cmd/apply/apply.go Outdated Show resolved Hide resolved
pkg/cmd/apply/apply.go Show resolved Hide resolved
pkg/cmd/apply/apply.go Outdated Show resolved Hide resolved
pkg/cmd/apply/apply.go Show resolved Hide resolved
pkg/apis/status/v1/types.go Outdated Show resolved Hide resolved
pkg/engine/operation/apply.go Show resolved Hide resolved
pkg/engine/runtime/kubernetes/kubernetes_runtime.go Outdated Show resolved Hide resolved
pkg/engine/runtime/terraform/terraform_runtime.go Outdated Show resolved Hide resolved
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan enabled auto-merge (squash) June 4, 2024 08:37
@SparkYuan SparkYuan merged commit aabbb5e into KusionStack:main Jun 4, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: kusion apply and destroy support checking the reconcile result while deploying
3 participants