-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: merge pkg operation/models to operation/types #198
Conversation
1eb10da
to
3ece8f4
Compare
Pull Request Test Coverage Report for Build 3739387346
💛 - Coveralls |
|
Yeah, I read this comment, but still confused about the differences between package models and types. First, pkg/engine/operation/types has two Definition:
why split them into 2 packages? |
for better understanding, merge into |
3ece8f4
to
adcf2c4
Compare
adcf2c4
to
ef441d7
Compare
Pkg
operation
has two sub pkg,models
andtypes
, they are written for same usages, so merge them to one pkg.For avoiding import path collision, takes
types
as the final choice.This PR changes 20+ files, mostly changes are
import
path and format.