Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BungeeCord: BossBar compatibilty with BungeeCord 1.20-R0.2 and newer #153

Merged
merged 8 commits into from
May 7, 2024
Merged

BungeeCord: BossBar compatibilty with BungeeCord 1.20-R0.2 and newer #153

merged 8 commits into from
May 7, 2024

Conversation

bivashy
Copy link
Contributor

@bivashy bivashy commented Feb 17, 2024 •
edited
Loading

Description
This Pull Request updates the method for changing the BossBar title to use TextComponent.fromArray(BaseComponent[]) instead of ComponentSerializer.toString(BaseComponent[]).

Additionally, it adds the minecraft-libraries repository because the new bungeecord-api depends on com.mojang:brigadier, which requires minecraft-libraries.

Related Issue: #152

kezz
kezz previously requested changes Feb 18, 2024
View reviewed changes
Copy link
Member

@kezz kezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just a few bits that need to change to make it more in line with the rest of library.

platform-bungeecord/src/main/java/net/kyori/adventure/platform/bungeecord/BungeeFacet.java Outdated Show resolved Hide resolved
@bivashy
Copy link
Contributor Author

bivashy commented Feb 18, 2024 •
edited
Loading

Concerns:

  1. Consider using MethodLookup for method invocation.
  2. Need clarity on using Bungee serializer to convert BaseComponent[] to BaseComponent (or TextComponent). Consider GsonComponentSerializer?

I can't figure out the above concerns

@bivashy
Copy link
Contributor Author

bivashy commented Feb 19, 2024

Done:

  • Cached MethodLookup to call BossBar#setTitle(String) or BossBar#setTitle(BaseComponent).
  • Backward compatibility with older versions of BungeeCord

Please let me know if there are needed changes!

@bivashy bivashy requested a review from kezz February 20, 2024 19:05
@bivashy
Copy link
Contributor Author

bivashy commented Feb 23, 2024

Any update on this Pull Request?

NoJokeFNA
NoJokeFNA suggested changes Mar 1, 2024
View reviewed changes
Copy link

@NoJokeFNA NoJokeFNA left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that it look good to me. Though I didn't test it

platform-bungeecord/src/main/java/net/kyori/adventure/platform/bungeecord/BungeeReflection.java Outdated Show resolved Hide resolved
platform-bungeecord/src/main/java/net/kyori/adventure/platform/bungeecord/BungeeReflection.java Outdated Show resolved Hide resolved
@bivashy
Copy link
Contributor Author

bivashy commented Mar 4, 2024

Tested with: git:BungeeCord-Bootstrap:1.20-R0.3-SNAPSHOT:eda268b:1797 and git:BungeeCord-Bootstrap:1.16-R0.5-SNAPSHOT:d49e97c:1575, it works as expected.

@bivashy

This comment was marked as off-topic.

Sign in to view
@zml2008 zml2008 self-assigned this May 7, 2024
@zml2008 zml2008 added this to the 4.3.3 milestone May 7, 2024
@zml2008 zml2008 dismissed kezz’s stale review May 7, 2024 02:10

changes have been made

@zml2008 zml2008 linked an issue May 7, 2024 that may be closed by this pull request
NoSuchMethodError due to BossBar.setTitle(String) incompatibility with BungeeCord's BaseComponent update #152
Closed
@zml2008 zml2008 merged commit 8f5c0c2 into KyoriPowered:main May 7, 2024
@renovate renovate bot mentioned this pull request Oct 4, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoJokeFNA NoJokeFNA NoJokeFNA approved these changes

@zml2008 zml2008 zml2008 approved these changes

@kezz kezz Awaiting requested review from kezz

Assignees

@zml2008 zml2008

Labels
platform: bungeecord type: enhancement New feature or request
Projects
None yet
Milestone
4.3.3
Development

Successfully merging this pull request may close these issues.

NoSuchMethodError due to BossBar.setTitle(String) incompatibility with BungeeCord's BaseComponent update
4 participants
@bivashy @zml2008 @kezz @NoJokeFNA