Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BungeeCord: BossBar compatibilty with BungeeCord 1.20-R0.2 and newer #153

Merged
merged 8 commits into from
May 7, 2024
+121 −2
Merged

BungeeCord: BossBar compatibilty with BungeeCord 1.20-R0.2 and newer #153

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f933d13
Include minecraft-libraries repository
bivashy Feb 17, 2024
53bf72f
Switch to BaseComponent in BossBar#setTitle for API compatibility
bivashy Feb 17, 2024
d36cd91
Bump BungeeCord version
bivashy Feb 17, 2024
7f4dc01
Ensure backward compatibility when updating bossbar title
bivashy Feb 18, 2024
2e8fbf5
Use MethodHandles.lookup() to invoke BossBar#setTitle
bivashy Feb 19, 2024
de6e761
Match code formatting with rest of the codebase
bivashy Feb 29, 2024
5964a61
Fix code format violations
bivashy Mar 4, 2024
c36534b
Add missing argument into MethodHandle invocation
bivashy Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion platform-bungeecord/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ dependencies {
}
implementation project(":adventure-platform-facet")
api project(":adventure-text-serializer-bungeecord")
compileOnly 'net.md-5:bungeecord-api:1.16-R0.4'
compileOnly 'net.md-5:bungeecord-api:1.20-R0.2'
}
4 changes: 2 additions & 2 deletions platform-bungeecord/src/main/java/net/kyori/adventure/platform/bungeecord/BungeeFacet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@
import net.md_5.bungee.api.CommandSender;
import net.md_5.bungee.api.ProxyServer;
import net.md_5.bungee.api.chat.BaseComponent;
import net.md_5.bungee.api.chat.TextComponent;
import net.md_5.bungee.api.connection.Connection;
import net.md_5.bungee.api.connection.ProxiedPlayer;
import net.md_5.bungee.chat.ComponentSerializer;
import net.md_5.bungee.chat.TranslationRegistry;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
Expand Down Expand Up @@ -255,7 +255,7 @@ public void bossBarInitialized(final net.kyori.adventure.bossbar.@NotNull BossBa
@Override
public void bossBarNameChanged(final net.kyori.adventure.bossbar.@NotNull BossBar bar, final @NotNull Component oldName, final @NotNull Component newName) {
if (!this.viewers.isEmpty()) {
this.bar.setTitle(ComponentSerializer.toString(this.createMessage(this.viewers.iterator().next(), newName)));
this.bar.setTitle(TextComponent.fromArray(this.createMessage(this.viewers.iterator().next(), newName)));
bivashy marked this conversation as resolved.
Show resolved Hide resolved
this.broadcastPacket(ACTION_TITLE);
}
}
Expand Down
7 changes: 7 additions & 0 deletions settings.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,13 @@ dependencyResolutionManagement {
includeGroup "com.destroystokyo.paper"
}
}
maven {
name "minecraft-libraries"
url "https://libraries.minecraft.net"
mavenContent {
includeGroup "com.mojang"
}
}
}
}

Expand Down