Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retrieve resourceTemplates from trellis server #309

Closed
ndushay opened this issue Jan 25, 2019 · 5 comments
Closed

retrieve resourceTemplates from trellis server #309

ndushay opened this issue Jan 25, 2019 · 5 comments
Assignees

Comments

@ndushay
Copy link
Contributor

ndushay commented Jan 25, 2019

depends on templates already being in server: LD4P/sinopia_server/issues/38

At first, ok if proof of concept shows that it was retrieved somehow (in console? as initial template???)

@jermnelson
Copy link
Contributor

I think if we can pull the currently spoofed resourceTemplate:bf2:Monograph:Instance as the initial template in a that would be a great proof-of-concept.

@ndushay
Copy link
Contributor Author

ndushay commented Jan 26, 2019

great idea, Jeremy! i'll make it a priority.

@ndushay ndushay removed their assignment Feb 11, 2019
@ndushay ndushay added to do and removed in progress labels Feb 11, 2019
@jermnelson jermnelson mentioned this issue Mar 8, 2019
7 tasks
@mjgiarlo mjgiarlo self-assigned this Mar 12, 2019
mjgiarlo added a commit that referenced this issue Mar 14, 2019
* Rename `sinopiaServerSpoof` to `sinopiaServer` in preparation for work in earnest on #309.
* Prefer `import ... from` load syntax to `const ... require()`.
* Use Array functions `map()` and `find()` in `sinopiaServer.js` instead of looping over arrays.
* Add docker-compose configuration so the editor can integrate with the Sinopia platform in dev/test.
* Use CircleCI's node image so we get `dockerize` for free (HT: @ndushay!).
* Use port 8888 for `webpack-dev-server` to prevent conflict with Trellis on port 8080, and reflect this change in integration tests.
* Bump Jest timeout length on integration tests (they fail otherwise on my laptop, and I want 💚 before I touch anything more).
* Extend eslint `node/no-unsupported-features/es-syntax` override to all JS files under `src/`, `__tests__`, and `__mocks__`, instead of onesy-twoying it, which should mean we don't have to touch this block again when adding new files.

connects to #309
mjgiarlo added a commit that referenced this issue Mar 15, 2019
Set default value to enable spoofing and explicitly set this value in the editor service in docker-compose to retain current behavior

connects to #309
@mjgiarlo mjgiarlo assigned jgreben and unassigned mjgiarlo Mar 20, 2019
@jgreben jgreben added to do and removed in progress labels Mar 28, 2019
@jgreben jgreben changed the title retrieve resourceTemplate from server load to and retrieve resourceTemplates from trellis server Mar 28, 2019
@jgreben
Copy link
Contributor

jgreben commented Mar 28, 2019

In the editor when you drop a resource template or profile file to be loaded, it will:

  • parse the file for contained resource templates
  • check if the rtId already exists
  • POST the RT data to Trellis under a group (they choose their group from a list)
  • re-display the table of resource templates including the newly loaded resource templates

@jermnelson jermnelson mentioned this issue Mar 28, 2019
11 tasks
@jgreben jgreben removed the to do label Mar 28, 2019
@jgreben
Copy link
Contributor

jgreben commented Apr 16, 2019

Fixed by #453

@mjgiarlo mjgiarlo changed the title load to and retrieve resourceTemplates from trellis server retrieve resourceTemplates from trellis server Apr 17, 2019
@mjgiarlo
Copy link
Member

Extracted #459 from this issue.

@jgreben jgreben closed this as completed Apr 24, 2019
mjgiarlo added a commit that referenced this issue Apr 24, 2019
Set default value to enable spoofing and explicitly set this value in the editor service in docker-compose to retain current behavior

connects to #309

Add configuration variables for sinopia server and ES URLs, and create a script to iterate over and load resource templates into Trellis

Retrieve resources from Trellis

Checkpoint commit

* Successfully injecting env vars into container via docker-compose
* Script to create RTs and containers works
* Able to read RTs out, but running into async/await issues with React

This may or may not be needed for the variable injection work
mjgiarlo added a commit that referenced this issue Apr 24, 2019
Set default value to enable spoofing and explicitly set this value in the editor service in docker-compose to retain current behavior

connects to #309

Add configuration variables for sinopia server and ES URLs, and create a script to iterate over and load resource templates into Trellis

Retrieve resources from Trellis

Checkpoint commit

* Successfully injecting env vars into container via docker-compose
* Script to create RTs and containers works
* Able to read RTs out, but running into async/await issues with React

This may or may not be needed for the variable injection work
@ndushay ndushay added the M3 label Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants