Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow editor to be configured via environment variables #459

Closed
3 tasks done
mjgiarlo opened this issue Apr 17, 2019 · 0 comments · Fixed by #466
Closed
3 tasks done

Allow editor to be configured via environment variables #459

mjgiarlo opened this issue Apr 17, 2019 · 0 comments · Fixed by #466
Assignees
@mjgiarlo
Labels
enhancement New feature or request

Comments

@mjgiarlo
Copy link
Member

mjgiarlo commented Apr 17, 2019 •
edited
Loading

Includes:

  • Inject environment variables the editor can see and use via Docker in order to disable/enable spoofing and set the sinopia server URL
    • Scan for other process.env vars and make sure these are injectable and accessible in React as well
  • Make sinopiaServer.js use configuration for deciding where to find resource templates

This was extracted from #309.
@mjgiarlo mjgiarlo added enhancement New feature or request in progress labels Apr 17, 2019
@mjgiarlo mjgiarlo self-assigned this Apr 17, 2019
This was referenced Apr 17, 2019
Closed
Closed
@mjgiarlo mjgiarlo mentioned this issue Apr 24, 2019
Merged
mjgiarlo added a commit that referenced this issue Apr 24, 2019
@mjgiarlo
Load resource templates into Sinopia platform
0d5e4ab 
Fixes #459

Includes:

* Add configuration for disabling/enabling spoofing
  * Set default value to enable spoofing and explicitly set this value in the editor service in docker-compose to retain current behavior
* Add configuration variables for Sinopia server and ES URLs
* Create a script to iterate over and load resource templates into Trellis
* Inject environment variables the editor can see and use via Docker in order to disable/enable spoofing and set the Sinopia server URL
@ndushay ndushay added the M3 label Apr 25, 2019
mjgiarlo added a commit that referenced this issue Apr 25, 2019
@mjgiarlo
Allow environment variable injection from containerland into application
6fddd60 
Fixes #459

Includes:
* Add configuration for disabling/enabling spoofing
  * Set default value to enable spoofing and explicitly set this value in the editor service in docker-compose to retain current behavior
* Add configuration variables for Sinopia server and ES URLs
* Inject environment variables the editor can see and use via Docker in order to disable/enable spoofing and set the Sinopia server URL
mjgiarlo added a commit that referenced this issue Apr 25, 2019
@mjgiarlo
Allow environment variable injection from containerland into application
ac6d212 
Fixes #459

Includes:
* Add configuration for disabling/enabling spoofing
  * Set default value to enable spoofing and explicitly set this value in the editor service in docker-compose to retain current behavior
* Add configuration variables for Sinopia server and ES URLs
* Inject environment variables the editor can see and use via Docker in order to disable/enable spoofing and set the Sinopia server URL
mjgiarlo added a commit that referenced this issue Apr 25, 2019
@mjgiarlo
Allow environment variable injection from containerland into application
adb3ed6 
Fixes #459

Includes:
* Add configuration for disabling/enabling spoofing
  * Set default value to enable spoofing and explicitly set this value in the editor service in docker-compose to retain current behavior
* Add configuration variables for Sinopia server and ES URLs
* Inject environment variables the editor can see and use via Docker in order to disable/enable spoofing and set the Sinopia server URL
mjgiarlo added a commit that referenced this issue Apr 25, 2019
@mjgiarlo
Allow environment variable injection from containerland into application
53a2659 
Fixes #459

Includes:
* Add configuration for disabling/enabling spoofing
  * Set default value to enable spoofing and explicitly set this value in the editor service in docker-compose to retain current behavior
* Add configuration variables for Sinopia server and ES URLs
* Inject environment variables the editor can see and use via Docker in order to disable/enable spoofing and set the Sinopia server URL
* Favor `getResourceTemplate()` over `getResourceTemplateFromServer()` to allow switching behavior (namely where the RTs are coming from) via env vars.
* Reduce number of max warnings for eslint failures
* Update npm package dependencies
mjgiarlo added a commit that referenced this issue Apr 25, 2019
@mjgiarlo
Allow environment variable injection from containerland into application
aadd9d6 
Fixes #459

Includes:
* Add configuration for disabling/enabling spoofing
  * Set default value to enable spoofing and explicitly set this value in the editor service in docker-compose to retain current behavior
* Add configuration variables for Sinopia server and ES URLs
* Inject environment variables the editor can see and use via Docker in order to disable/enable spoofing and set the Sinopia server URL
* Favor `getResourceTemplate()` over `getResourceTemplateFromServer()` to allow switching behavior (namely where the RTs are coming from) via env vars.
* Reduce number of max warnings for eslint failures
@mjgiarlo mjgiarlo changed the title Load initial set of resource templates into server Allow editor to be configured via environment variables Apr 26, 2019
@dependabot-preview dependabot-preview bot mentioned this issue Oct 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjgiarlo mjgiarlo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow environment variable injection from containerland into application LD4P/sinopia_editor
3 participants
@jermnelson @ndushay @mjgiarlo