feat(bar): optional workspaces on Komorebi widget #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-ds13
force-pushed
the
fix(bar)/optional-workspaces
branch
2 times, most recently
from
9a9dd0b to
7b856f7
Compare
alex-ds13
force-pushed
the
fix(bar)/optional-workspaces
branch
from
7b856f7 to
57e5c02
Compare
|
Ah sorry, this might need another rebase; I updated the icon size commit message to include the context that was on the PR |
This commit makes the `workspaces` on `Komorebi` widget optional. This way it allows adding the `workspaces` on one Alignment and the `focused_window` on another one, for example.
alex-ds13
force-pushed
the
fix(bar)/optional-workspaces
branch
from
57e5c02 to
53c74a2
Compare
Should be good to go now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the
workspacesonKomorebiwidget optional. This way it allows adding theworkspaceson one Alignment and thefocused_windowon another one, for example.For some reason if you had some widget on thecenter_widgetswith only icons, like thefocused_windowwith just icons or theworkspaceswith just icons and nothing else, EGUI wouldn't show the icon properly. I believe that on the first frame the icons might not have been loaded yet, so it set the height of thecenter_widgetsArea to 0 and afterwards it wouldn't grow to fit the icons unless we've made some config change for example.To fix this we've made the icons have fixed size which is equal to the font size. For this it was required that the font size was added to theRenderConfigso that the widgets would have access to it when rendering.This fix was done by @CtByte on PR #1184 as well with the scaling of icons, so this PR was rebased to that one to make use of said fix. This PR should only be merged after #1184 is merged to avoid conflicts.