feat(bar): scaled icon size relying on the font size #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LGUG2Z The scaling can be added to the config if you find that to be necessary. Please let me know if you have any thoughts on that |
CtByte
force-pushed
the
bar_icon_size
branch
from
23db714 to
fed9aa7
Compare
CtByte
force-pushed
the
bar_icon_size
branch
from
fed9aa7 to
80fdb8d
Compare
This was referenced Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the way icons are displayed on the bar. There was an issue with how app icons were sized using
shrink_to_fit. This has been changed to usefit_to_exact_sizeinstead, relying on the font size as a starting point and scaling it to1.4of its size, making the icons to appear larger.The same scaling was done to all the widget icons as well to make them look unified.
Recording.2024-12-17.002044.mp4
Special thanks to @alex-ds13 for initiating this change. It would be most appreciated if this PR is merged before his