Fix #225: use temporary RTs with the active camera dimensions for ocean renderer #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for ocean renderer -fixes rendering in VR because it automatically gets the right size no matter what the camera dimensions are -also doesn't require special screenshot handling
LGhassen
reviewed
Nov 23, 2024
| if (oceanScreenShotModeEnabled != screenShotModeEnabled) | ||
| { | ||
| // Resize textures | ||
| int superSizingFactor = screenShotModeEnabled ? Mathf.Max(GameSettings.SCREENSHOT_SUPERSIZE, 1) : 1; |
There was a problem hiding this comment.
I am pretty sure that temporary RTs don't detect/work correctly for supersized screenshots. You can leave it like this for now, but I have a branch with new ocean features using tempRTs which I will probably have to check after merging this.
There was a problem hiding this comment.
I did test this and it seemed fine.
JonnyOThan
commented
Nov 28, 2024
|
|
||
| void CreateRenderTextures () | ||
| { | ||
| targetCamera.forceIntoRenderTexture = true; //do this to force the camera target orientation to always match depth orientation |
There was a problem hiding this comment.
I think this line may have been lost, not sure if it’s important.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes rendering in VR because it automatically gets the right size no matter what the camera dimensions are
also doesn't require special screenshot handling