rcb: remove async implementation #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
==========================================
- Coverage 51.74% 51.01% -0.74%
==========================================
Files 42 41 -1
Lines 7251 6979 -272
==========================================
- Hits 3752 3560 -192
+ Misses 3499 3419 -80
Continue to review full report at Codecov.
|
for simplicity's sake Zoltan2 uses the same BSP paradigm + data movements, so the simple_rcb version is state of the art. A next step would be to improve data locality with custom rayon drivers. This commit removes the relevant dependencies, and also removes the indirect dependency on proc-macros via nalgebra-macros and tracing.
instead, keep track of the bounding boxes and the sum of the parts. This reduces the load of high-iter-count runs.
Since this makes half as many float comparisons and select_nth_unstable ends up only matching for Ordering::Less anyway: https://github.com/rust-lang/rust/blob/cb0584f86b8cfa952dffad55f7d83bd90765120f/library/core/src/slice/mod.rs#L2719
It's slower to go through rayon than to sort+split them.
|
Codecov seems to complain because lot of previously-covered lines were deleted? Though the coverage diffs are all on the positive side (except for the spurious vnfirst :/) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and improve the simple one by:
geometry::BoundingBoxto keep track of min and maxcrate::partial_cmpto use half as much float comparisonsdepends on #164