Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rcb: remove async implementation #165

Merged
merged 5 commits into from
Jun 7, 2022
Merged

rcb: remove async implementation #165

merged 5 commits into from
Jun 7, 2022

Commits on Jun 7, 2022

  1. rcb: remove async implementation 

    for simplicity's sake

Zoltan2 uses the same BSP paradigm + data movements, so the simple_rcb
version is state of the art.  A next step would be to improve data
locality with custom rayon drivers.

This commit removes the relevant dependencies, and also removes the
indirect dependency on proc-macros via nalgebra-macros and tracing.
    @hhirtz
    hhirtz committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    c0729cf View commit details
    Browse the repository at this point in the history

  2. rcb: avoid re-computations of min/max/sum 

    instead, keep track of the bounding boxes and the sum of the parts.

This reduces the load of high-iter-count runs.
    @hhirtz
    hhirtz committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    3981bf1 View commit details
    Browse the repository at this point in the history

  3. rcb: use crate::partial_cmp for select_nth 

    Since this makes half as many float comparisons and select_nth_unstable
ends up only matching for Ordering::Less anyway:
https://github.com/rust-lang/rust/blob/cb0584f86b8cfa952dffad55f7d83bd90765120f/library/core/src/slice/mod.rs#L2719
    @hhirtz
    hhirtz committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    22c888b View commit details
    Browse the repository at this point in the history

  4. rcb: don't split small item sets in parallel 

    It's slower to go through rayon than to sort+split them.
    @hhirtz
    hhirtz committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    cbd9aa2 View commit details
    Browse the repository at this point in the history

  5. rcb: ensure correct alignment during transmute

    @hhirtz
    hhirtz committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    048e29f View commit details
    Browse the repository at this point in the history