-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Piano roll grid enchancement #1842
Comments
I tweaked something like this into the automation editor, but never got around to do the same to the piano roll. If someone feels the urge to do something about this issue, I suggest a look at #426 for inspiration. |
I fixed most of this in #3062. The quintole and septole support is an issue with our quantisation and I feel like it could be a seperate issue. |
👍 to a separate 'tuplet' issue. |
So is there any chance that using quintoles and septoles will be possible in the future? |
Yes. Shouldn't be too complicated to implement but I haven't got the time to do it personally. |
@Umcaruje |
No, actually the bar shading is first drawn and the rest is drawn over it.
look at the bar grid color. what you're seeing is because the notes are
transparent and their background inevitably influences the final color
cause it gets mixed together. But no, shading is not drawn over the notes.
…On 25 Jun 2017 08:15, "musikBear" ***@***.***> wrote:
@Umcaruje <https://github.com/umcaruje>
the layer-sequence in piano-roll looks flawed.
The bar-*shading* is placed *over* the notes.
Shading is lowest layer number. It ought to be notes.
If a note stretches over +1 bar the color of the note will be influenced
Note-Color over;
unshaded bar: #0C662E
shaded bar: #0F6931
It results in difficulties determining the note-length, and is strangely
tiresome for the eyes -it seams 'blurry'
[image: shadevunshade]
<https://user-images.githubusercontent.com/6662066/27514037-29e9d8a8-597e-11e7-8445-a28a3ff9f020.JPG>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1842 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AF_bPfniED0ngNuy941Jm-UN2tdCftAPks5sHfsNgaJpZM4DrYiR>
.
|
ahhh yes they are transparent.. So that blur is a kind of 'moire' with two alpha-channels.. phff.. That would not be a simple fix |
@musikBear I am open to tweaking the shades of colors and opacity in related to the grid if need be, but I have not heard of anyone else having difficulty with this. This might be one of those elements that you need to edit in the style.css individually. |
This is done in master, aside from the green vertical bars which *Edit: correction thanks to @Veratil * |
It would be really great to have an option, which would allow you to have the grid "resolution" match the quantization value. What I mean, is that when you set quantization to 1/16 or 1/8, the notes you draw are snapped to the vertical lines, that designate the boundaries between the notes of the corresponding length. So it will make much more sense just to hide other lines completely, since they are useless anyway and only clutter the view. Its even hard to tell where 2 and 4 are in the bar, because lines look almost the same. The other thing it would be great to have, is the ability to use 1/5, 1/7, 1/9 notes and their derivatives. Also it would be handy to have rows corresponding to black and white keys differ in color.
The text was updated successfully, but these errors were encountered: