Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piano roll grid enchancement #1842

Open
z-up opened this issue Mar 8, 2015 · 11 comments
Open

Piano roll grid enchancement #1842

z-up opened this issue Mar 8, 2015 · 11 comments

Comments

@z-up
Copy link
Contributor

z-up commented Mar 8, 2015

It would be really great to have an option, which would allow you to have the grid "resolution" match the quantization value. What I mean, is that when you set quantization to 1/16 or 1/8, the notes you draw are snapped to the vertical lines, that designate the boundaries between the notes of the corresponding length. So it will make much more sense just to hide other lines completely, since they are useless anyway and only clutter the view. Its even hard to tell where 2 and 4 are in the bar, because lines look almost the same. The other thing it would be great to have, is the ability to use 1/5, 1/7, 1/9 notes and their derivatives. Also it would be handy to have rows corresponding to black and white keys differ in color.

@softrabbit
Copy link
Member

I tweaked something like this into the automation editor, but never got around to do the same to the piano roll. If someone feels the urge to do something about this issue, I suggest a look at #426 for inspiration.

@tresf tresf added this to the 1.3.0 milestone Mar 9, 2015
@Umcaruje Umcaruje added the gui label Jul 5, 2015
@Umcaruje
Copy link
Member

I fixed most of this in #3062. The quintole and septole support is an issue with our quantisation and I feel like it could be a seperate issue.

@zonkmachine
Copy link
Member

The quintole and septole support is an issue with our quantisation and I feel like it could be a seperate issue.

👍 to a separate 'tuplet' issue.

@z-up
Copy link
Contributor Author

z-up commented Mar 29, 2017

The quintole and septole support is an issue with our quantisation and I feel like it could be a seperate issue.

So is there any chance that using quintoles and septoles will be possible in the future?

@zonkmachine
Copy link
Member

So is there any chance that using quintoles and septoles will be possible in the future?

Yes. Shouldn't be too complicated to implement but I haven't got the time to do it personally.

@RebeccaDeField
Copy link
Contributor

Seems like a separate issue should be created regarding the the quintole and septole support and this should be closed out or edited to only include the relevant information.

@z-up @Umcaruje

@musikBear
Copy link

@Umcaruje
the layer-sequence in piano-roll looks flawed.
The bar-shading is placed over the notes.
Shading is lowest layer number. It ought to be notes.
If a note stretches over +1 bar the color of the note will be influenced
Note-Color over;
unshaded bar: #0C662E
shaded bar: #0F6931
It results in difficulties determining the note-length, and is strangely tiresome for the eyes -it seams 'blurry'
shadevunshade

@Umcaruje
Copy link
Member

Umcaruje commented Jun 25, 2017 via email

@musikBear
Copy link

ahhh yes they are transparent.. So that blur is a kind of 'moire' with two alpha-channels.. phff.. That would not be a simple fix
Tell me, do you also see that 'blurriness' in the shaded grid-part 'around' the note - to my lousy eyes its like there is a 'fatter' note inside the shading, like a 'bleed over' between the colors. If you (others) also see this, then the question could be, if the two colors (notes v. background) are too similar, and the notes maby should be complementary in respect to the background, eg swap green for red? -That would also need @RebeccaLaVie input, cause its her design

@RebeccaDeField
Copy link
Contributor

@musikBear I am open to tweaking the shades of colors and opacity in related to the grid if need be, but I have not heard of anyone else having difficulty with this. This might be one of those elements that you need to edit in the style.css individually.

@Spekular
Copy link
Member

Spekular commented Mar 12, 2021

This is done in master, aside from the green vertical bars which are always displayed at 1/4th note positions depend on the time signature.

*Edit: correction thanks to @Veratil *

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants