AutomationEditor: fix grid scrolling and non-4/4 time signatures #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an 4/4 and scrolling should work quite a bit better.
|
All the more reason to get rid of odd denominators, IMO... |
|
BTW, in this version every level of lines on the X scale is informative (bar - beat (time signature denominator) - quantization), is this a good thing or will it confuse users? If it's good, the piano roll could get the same treatment. |
added 5 commits
March 14, 2014 20:44
|
Made a new PR on the master branch, closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #283 and closes #303.
BUT, please don't put this in 1.0.0, at least not without thorough testing! There might be some place where
DefaultTicksPerTactshould not be changed toMidiTime::ticksPerTact().If the time signature has an odd denominator, there will be two grids visible, one from the time signature and one from the quantization, not lining up nicely.