2 "Beat+Bassline Editor" GUI bugs.

[husamalhomsi]

There are 2 bugs with the "Beat+Bassline Editor".

(1) The first bug: the right side of the "B+B E" near the last 2 steps of the fourth beat gets cropped when the "B+B E" opens.

An example:
Opening LMMS then opening the "B+B E":

(2) The second bug: when the "B+B E" is moved, the first bug disappears, but the "B+B E" takes a piece of the windows that is behind it and put it in its window near the last 2 steps of the fourth beat.

The first example:
Opening LMMS with the "Song-Editor" in view (this happens by default) then opening the "B+B E" then moving the "B+B E":

The second example:
Opening LMMS with the "Song-Editor" in view (this happens by default) then opening the "B+B E" then closing the "Song-Editor" (so the "B+B E" is over the "Automation Editor") then moving the "B+B E":

The third example:
Opening LMMS with the "Song-Editor" in view (this happens by default) then opening the "B+B E" then closing the "Song-Editor" then closing the "Automation editor" (so the "B+B E" is over the blank background) then moving the "B+B E":

• The second bug happens with instrument plug-ins, too.

[BaraMGB]

both bugs confirmed. They are related. I look into it.

[BaraMGB]

A quick workaround is to resize the bbEditor window.

The problem here is, the size of the window is saved with the project. But our new theme uses more space in width for the B+B editor. So the right side is cropped.

[husamalhomsi]

A quick workaround is to resize the bbEditor window.

I'm aware of that.

[BaraMGB]

Okay, after a deeper dive into this problem I found it. If a project will be saved and a window is hidden a given size will be saved with the project. In case of the BB Editor this is 640 x 400 Pixel.

https://github.com/LMMS/lmms/blob/stable-1.2/src/gui/MainWindow.cpp#L760

@Wallacoloo Do you know why this is necessary? This leads to this bug.

[Wallacoloo]

@BaraMGB I vaguely remember changing that code. IIRC: Previously, the behavior was that all open windows have their positions/sizes saved so that the workspace remains identical when the project is reopened. But oftentimes people arrange the windows specifically (e.g. mixer on right, B+BE on left) and minimize/hide them when not in use. When they save the project & these windows aren't visible, the position/size wasn't reported correctly, so their location wouldn't be preserved when opening the project again - I think they were saved with a size of (0, 0) and would be tiny when reopened.

The fix was to add that QSize sizeToStore = visible ? normalGeom.size() : sizeIfInvisible; line, to have some sane default (as opposed to a 0x0 window). I thought it had been implemented in a way where we would save the window's size prior to being minimized, but I guess not.

If it's introducing problems, it should be safe to modify so long as you test the behavior of loading a project with minimized windows afterward.

[Umcaruje]

loading a project with minimized windows afterward.

We removed minimization of windows, they can only get closed now.

[Wallacoloo]

It might have covered both minimized and closed windows - not sure (maybe hunt down the commit message).

…

On May 29, 2017 2:42 PM, "Umcaruje" ***@***.***> wrote: loading a project with minimized windows afterward. We removed minimization of windows, they can only get closed now. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3584 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABJ5f9c13lsByY5kJXjMjW-b6hCWwgESks5r-zvZgaJpZM4NoyZN> .

[BaraMGB]

If we'd fix that and save the actually size no matter the window is hidden or not the problem persist for older projects. It would be only fixed for projects which will be saved with this new program version.