saves the correct subwindow size when it is hidden

[BaraMGB]

fixes #3584

[Wallacoloo]

Now that the sizeIfInvisible parameter is unused, it should probably be removed from the function signature as well.

[BaraMGB]

@Wallacoloo 👍

[qnebra]

Possibly bug, how to reproduce:

1. Open lmms with this branch merged
2. New default project opened.
3. Try open Pianoroll, Automation editor, Project notes,
4. Nothing happens, they aren't shown or they just invisible. I don't know.
5. Try open Song Editor, B+B Editor, Mixer, Controller Rack
6. They opens like always will be.

GIF for proof:
http://imgur.com/fzemcyU

[BaraMGB]

@qnebra I can't reproduce. :( More people needed for testing here! @tresf @Umcaruje

[qnebra]

Ok, maybe it's fixed and I just making unnecesary noise. Ok, you fixed this.

[zonkmachine]

Spaces at in the parenthesis.

[zonkmachine]

I've tested this and I haven't noticed anything out of the ordinary. Fix the spaces (comment above) and merge this.

[BaraMGB]

@qnebra has objections. I talked to him in discord. He can reproduce the problems after checkout this branch. There seems to be something fishy.

[qnebra]

I don't know exactly how it worked, in my case it look like "pianoroll", "automation editor", "project notes" windows dimensions are set to 0x0, so you can't find them, but they are active.

Maybe it's something specific, unable to reproduce.

[zonkmachine]

@BaraMGB Can you rebase this against stable-1.2 ?
I added a default template in ac9f4a2 and if there is a bug with new projects/templates, this is going to affect this PR.

@qnebra
Can you paste back the output of git log --oneline -n 10 ?
Do you have a local default project template? (Save as default tempate?).
Can you try a clean build?

[qnebra]

@zonkmachine

1. git log --oneline -n 10
   805ed24 remove invisible size from saveWidgetState()
   a82462f saves the correct subwindow size when it is hidden
   f1a3368 Merge pull request Fix CMP0050 compilation warnings #3583 from tresf/stable-1.2
   745042d Fix CMP0050 compilation warnings
   3607c92 Bitcrush Plugin Redesign (Bitcrush Plugin Redesign #3575)
   38bca9a fix time signature updates timelinewidget also on pos 0 (fix time signature updates timelinewidget also on pos 0 #3572)
   f8a508f Fixes Pattern length does not change automatically while shifting notes #3563 (Automatically change pattern lengths after shifting note positions(Fixes #3563) #3567)
   6970c88 fix alternate shading for changing time signature (fix alternate shading for changing time signature #3559)
   c0b910e Replacement metronome samples (Replacement metronome samples #3513)
   300058d Flanger LFO rate syncronised (Flanger LFO rate syncronised #3521)

2. Yes, I have.

3. I will try.

Ok guys, very, very sorry for noise. Create a new one default template fixed issue locally.

[zonkmachine]

Ok guys, very, very sorry for noise. Create a new one default template fixed issue locally.

No, that is a concern. I still think we need to test this with the new template fix.

[BaraMGB]

@zonkmachine done

[zonkmachine]

Works fine here like before.

@qnebra Can you build and test this? Test it both with and without the template you made.

[qnebra]

@zonkmachine Ok, I hope delete new default template will help test. Now install.
It's look like fixed, I haven't issue now.

[zonkmachine]

That'll do. Merge! 🚜

[BaraMGB]

👍 Thanks to @qnebra and @zonkmachine !

[tresf]

Cherry-picked and ready for master in 220559f.