Fix producing of NaN from Env/LFO parameter change while playing. #3761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guarantee thread safety to ensure fillLevel() not to read value from wrong buffer address.
Closed
michaelgregorius
requested changes
Aug 10, 2017
There was a problem hiding this comment.
Please use QMutexLockers to ensure safe unlocking in cases of exceptions, etc.
| @@ -291,6 +291,8 @@ void EnvelopeAndLfoParameters::fillLevel( float * _buf, f_cnt_t _frame, | |||
| const f_cnt_t _release_begin, | |||
| const fpp_t _frames ) | |||
| { | |||
| m_paramMutex.lock(); | |||
There was a problem hiding this comment.
Please use a QMutexLocker here to ensure safe unlocking in cases of exceptions, etc.
| @@ -402,6 +406,8 @@ void EnvelopeAndLfoParameters::loadSettings( const QDomElement & _this ) | |||
|
|
|||
| void EnvelopeAndLfoParameters::updateSampleVars() | |||
| { | |||
| m_paramMutex.lock(); | |||
There was a problem hiding this comment.
Please use a QMutexLocker here to ensure safe unlocking in cases of exceptions, etc.
|
@michaelgregorius Done via 667ee11. |
michaelgregorius
approved these changes
Aug 11, 2017
|
I'll merge it after 12~24 hours if there's no objection. |
PhysSong
added a commit
to PhysSong/lmms
that referenced
this pull request
Aug 19, 2017
…S#3761) Guarantee thread safety to ensure fillLevel() not to read value from wrong buffer address.
PhysSong
added a commit
to PhysSong/lmms
that referenced
this pull request
Aug 25, 2017
…S#3761) Guarantee thread safety to ensure fillLevel() not to read value from wrong buffer address.
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
…S#3761) Guarantee thread safety to ensure fillLevel() not to read value from wrong buffer address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3408.
Guarantee thread safety to ensure
fillLevel()not to read value from wrong buffer address, because of buffer reallocation inupdateSampleVars().