Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bgfx) Change parameters for is_frame_buffer_valid #993

Merged
merged 1 commit into from
Jul 12, 2024
Merged

fix(bgfx) Change parameters for is_frame_buffer_valid #993

merged 1 commit into from
Jul 12, 2024

Conversation

bonenaut7
Copy link
Contributor

BGFX's method bgfx::isFrameBufferValid takes array size, and array reference of Attachment's.
However in the bindings there is only single BGFXAttachment object, instead of BGFXAttachment.Buffer as it's done in the bgfx_create_frame_buffer_from_attachment.

I'm replaced MapToInt with AutoSize, now is_frame_buffer_valid has BGFXAttachment.Buffer and same buffer could be utilized both for validating attachments and creating framebuffer from attachments.

Adding missing AutoSize modifier and removed unnecessary MapToInt.
@Spasi Spasi merged commit 9cdc470 into LWJGL:master Jul 12, 2024
@Spasi
Copy link
Member

Spasi commented Jul 12, 2024

Thank you @bonenaut7!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants