Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bgfx) Change parameters for is_frame_buffer_valid #993

Merged
merged 1 commit into from
Jul 12, 2024
Merged

fix(bgfx) Change parameters for is_frame_buffer_valid #993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/notes/3.3.4.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ This build includes the following changes:

- Core: Fixed callback wrapper memory leak with the CHM closure registry. (#927)
- Core: The `SharedLibraryLoader` will now always test if `System::load` works before choosing the extract path. (#987)
- bgfx: Fixed `bgfx_is_frame_buffer_valid` to accept `BGFXAttachment.Buffer`. (#993)
- JAWT: Fixed `JAWT_MACOSX_USE_CALAYER` value.
- LLVM: Fixed `LLVMGetBufferStart` to return `ByteBuffer` instead of `String`. (#934)
- LLVM: Fixed `LookupIntrinsicID` to return `unsigned` instead of `void`. (#950)
Expand Down
11 changes: 7 additions & 4 deletions modules/lwjgl/bgfx/src/generated/java/org/lwjgl/bgfx/BGFX.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2985,7 +2985,11 @@ public static boolean bgfx_is_texture_valid(@NativeType("uint16_t") int _depth,

// --- [ bgfx_is_frame_buffer_valid ] ---

/** Unsafe version of: {@link #bgfx_is_frame_buffer_valid is_frame_buffer_valid} */
/**
* Unsafe version of: {@link #bgfx_is_frame_buffer_valid is_frame_buffer_valid}
*
* @param _num number of attachments
*/
public static boolean nbgfx_is_frame_buffer_valid(byte _num, long _attachment) {
long __functionAddress = Functions.is_frame_buffer_valid;
return invokeUPZ(_num, _attachment, __functionAddress);
Expand All @@ -2994,14 +2998,13 @@ public static boolean nbgfx_is_frame_buffer_valid(byte _num, long _attachment) {
/**
* Validate frame buffer parameters.
*
* @param _num number of attachments
* @param _attachment attachment texture info
*
* @return true if a frame buffer with the same parameters can be created
*/
@NativeType("bool")
public static boolean bgfx_is_frame_buffer_valid(@NativeType("uint8_t") int _num, @NativeType("bgfx_attachment_t const *") BGFXAttachment _attachment) {
return nbgfx_is_frame_buffer_valid((byte)_num, _attachment.address());
public static boolean bgfx_is_frame_buffer_valid(@NativeType("bgfx_attachment_t const *") BGFXAttachment.Buffer _attachment) {
return nbgfx_is_frame_buffer_valid((byte)_attachment.remaining(), _attachment.address());
}

// --- [ bgfx_calc_texture_size ] ---
Expand Down
2 changes: 1 addition & 1 deletion modules/lwjgl/bgfx/src/templates/kotlin/bgfx/templates/BGFX.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1544,7 +1544,7 @@ RGBA16S
"is_frame_buffer_valid",
"Validate frame buffer parameters.",

MapToInt..uint8_t("_num", "number of attachments"),
AutoSize("_attachment")..uint8_t("_num", "number of attachments"),
bgfx_attachment_t.const.p("_attachment", "attachment texture info"),

returnDoc = "true if a frame buffer with the same parameters can be created"
Expand Down