-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISO8601 ([T])TIME #17
Comments
@francois-normandin I think this part of the code is mostly working. I will submit pull request with my changes. Notes about existing tests:1. Strictly InvalidThese failing tests should be fixed and probably can be resolved with logic inside 2. Support for AmbiguousThis requires a discussion about what is/is not allowed in v1.3 release and whether the tests need to be changed or not. 3. RFC3339This one I don't understand: |
… strings - include updated unit tests inside Test Strict Ambiguous ISO8601 Strings.vi - some strictly invalid tests are failing
@ciozi137 I'm not sure where you get the failures in the tests you report above. In the current main branch, those are ALL passing. From this point, let's submit only changes that resolve tests that are breaking and do not break existing tests that passed. I would like that we submit changes to the test vectors before we resolve to fix potential issues, otherwise, we'll be working on false vectors are optimize the wrong outcome. |
About RFC3339, yes this is confusing. Let's track this in here |
@francois-normandin failures were in #18 |
The library parses a 'strict' ISO8601 string with
DATE
in many formats,DATETIME
with[T]
separator, andTIME
with a leading[T]
. It does not recognizeTIME
without leading[T]
is as strict ISO8601. However, the ISO8601 spec indicates that the leading[T]
is not necessary when the string is unambiguously a time.I propose the following functionality:
ISO8601 String to Timestamp.vi
(forStrict?==True
) will require a[T]
separator unless it can determine if the input string is unambiguously aDATE
or aTIME
.Note: it currently behaves this way except for
TIME
only.ISO8601 TimeString to Timestamp.vi
should not require leading[T]
separator as the method itself removes any ambiguity.ISO8601 DateString to Timestamp.vi
would not require a trailing[T]
because the input string would unambiguously be aDATE
.) 1This issue will continue discussion found in Issue #11
Footnotes
Perhaps this is a desirable method.
ISO8601 String to Timestamp.vi
could call bothISO8601 DateString to Timestamp.vi
andISO8601 TimeString to Timestamp.vi
and look for a[T]
to determine validity? ↩The text was updated successfully, but these errors were encountered: