Skip to content

Commit

Permalink
refactor: Remove redundant check in MultiWireStructureBuilder (acts-p…
Browse files Browse the repository at this point in the history
…roject#2824)

I removed some lines that check the dimensions of the trapezoid bounds since it is already checked in the volume structure builder that is called in the `construct` method of the `MultiWireStructureBuilder. `
Also, it does not allow for passing six parameters and using the six-parameter constructor of the `TrapezoidVolumeBounds`
I need to get rid of this in order to be able to pass all the bound values (six values) when constructing the bounds of MDTS in athena: 

` std::unique_ptr<Acts::TrapezoidVolumeBounds> mdtBounds = std::make_unique<Acts::TrapezoidVolumeBounds>(parameters.shortHalfX, parameters.longHalfX, parameters.halfY, parameters.halfHeight);
       mlCfg.mlBounds= mdtBounds->values();
                     `
  • Loading branch information
dimitra97 authored and LaraCalic committed Feb 10, 2024
1 parent 147888e commit 63d1378
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions Core/src/Detector/MultiWireStructureBuilder.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -116,12 +116,6 @@ Acts::Experimental::MultiWireStructureBuilder::MultiWireStructureBuilder(
Acts::Experimental::DetectorComponent
Acts::Experimental::MultiWireStructureBuilder::construct(
const Acts::GeometryContext& gctx) {
if (mCfg.mlBounds.size() != 4u) {
throw std::invalid_argument(
"MultiWireStructureBuilder: Invalid dimension for bounds. Trapezoid "
"Volume Bounds are supported.");
}

// Configure the external structure builder for the internal structure
Acts::Experimental::VolumeStructureBuilder::Config vsConfig;
vsConfig.boundsType = Acts::VolumeBounds::eTrapezoid;
Expand Down

0 comments on commit 63d1378

Please sign in to comment.