refactor: Remove redundant check in MultiWireStructureBuilder #2824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An indexed surfaces multilayer navigation Remove unused variable Remove unused variable fix type conversions for the number of bins changes on the mockupbuilder header file and on the unit test Update Core/include/Acts/Navigation/MultiWireLayerUpdators.hpp Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com> Change on test mockup builder script Multi Wire structure with the interface Changes on the multiwire structure builder Place the files that create the mockup geometry in another folder Change the location of the gdml file An indexed surfaces multilayer navigation Remove unused variable fix type conversions for the number of bins Multi Wire structure with the interface Delete MultiWireLayerUpdators.hpp Update CMakeLists.txt revert some files trying for Indexed Surfaces Generator Indexed Surfaces generator update fix LayerStructure builder fix fix Delete MuonChamber.gdml revert layer strucutre builder from upstream reslove conflict Multi Layer Builder cmake file Place the files that create the mockup geometry in another folder Change the location of the gdml file An indexed surfaces multilayer navigation Remove unused variable Remove unused variable fix type conversions for the number of bins Remove some actsvg includes not needed now change the path for the gdml file changes on the mockupbuilder header file and on the unit test Update Core/include/Acts/Navigation/MultiWireLayerUpdators.hpp Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com> Change on test mockup builder script Multi Wire structure with the interface Changes on the multiwire structure builder Place the files that create the mockup geometry in another folder Change the location of the gdml file An indexed surfaces multilayer navigation Remove unused variable fix type conversions for the number of bins Remove some actsvg includes not needed now change the path for the gdml file Multi Wire structure with the interface Delete MultiWireLayerUpdators.hpp Delete IndexedSurfacesNavigationTests.cpp Update CMakeLists.txt revert some files trying for Indexed Surfaces Generator Indexed Surfaces generator update fix LayerStructure builder fix fix Delete MuonChamber.gdml revert layer strucutre builder from upstream cmake file Update MultiWireStructureBuilder.hpp Update MultiWireStructureBuilder.hpp Update MultiWireStructureBuilder.cpp Place the files that create the mockup geometry in another folder Change the location of the gdml file An indexed surfaces multilayer navigation Remove unused variable Remove unused variable fix type conversions for the number of bins Remove some actsvg includes not needed now change the path for the gdml file changes on the mockupbuilder header file and on the unit test Update Core/include/Acts/Navigation/MultiWireLayerUpdators.hpp Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com> Change on test mockup builder script Multi Wire structure with the interface Changes on the multiwire structure builder Place the files that create the mockup geometry in another folder Change the location of the gdml file An indexed surfaces multilayer navigation Remove unused variable fix type conversions for the number of bins Remove some actsvg includes not needed now change the path for the gdml file Multi Wire structure with the interface Delete MultiWireLayerUpdators.hpp Delete IndexedSurfacesNavigationTests.cpp Update CMakeLists.txt revert some files trying for Indexed Surfaces Generator Indexed Surfaces generator update LayerStructure builder fix fix Delete MuonChamber.gdml revert gdml from upstream revert layer strucutre builder from upstream fix conflicts and some optimizations conflicts and format revert some files revert some files new updator fix license issue fix
dimitra97
force-pushed
the
mwbuilder-minor
branch
from
0ef7abb to
3f12232
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2824 +/- ##
=======================================
Coverage 48.85% 48.85%
=======================================
Files 486 486
Lines 28178 28175 -3
Branches 13292 13290 -2
=======================================
Hits 13766 13766
+ Misses 4796 4794 -2
+ Partials 9616 9615 -1 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for 3da2d79physmon summary
|
dimitra97
force-pushed
the
mwbuilder-minor
branch
from
da24acf to
c48137a
Compare
AJPfleger
approved these changes
Dec 14, 2023
paulgessinger
changed the title
LaraCalic
pushed a commit
to LaraCalic/acts
that referenced
this pull request
Feb 10, 2024
…roject#2824) I removed some lines that check the dimensions of the trapezoid bounds since it is already checked in the volume structure builder that is called in the `construct` method of the `MultiWireStructureBuilder. ` Also, it does not allow for passing six parameters and using the six-parameter constructor of the `TrapezoidVolumeBounds` I need to get rid of this in order to be able to pass all the bound values (six values) when constructing the bounds of MDTS in athena: ` std::unique_ptr<Acts::TrapezoidVolumeBounds> mdtBounds = std::make_unique<Acts::TrapezoidVolumeBounds>(parameters.shortHalfX, parameters.longHalfX, parameters.halfY, parameters.halfHeight); mlCfg.mlBounds= mdtBounds->values(); `
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed some lines that check the dimensions of the trapezoid bounds since it is already checked in the volume structure builder that is called in the
constructmethod of theMultiWireStructureBuilder.Also, it does not allow for passing six parameters and using the six-parameter constructor of the
TrapezoidVolumeBoundsI need to get rid of this in order to be able to pass all the bound values (six values) when constructing the bounds of MDTS in athena:
std::unique_ptr<Acts::TrapezoidVolumeBounds> mdtBounds = std::make_unique<Acts::TrapezoidVolumeBounds>(parameters.shortHalfX, parameters.longHalfX, parameters.halfY, parameters.halfHeight); mlCfg.mlBounds= mdtBounds->values();