Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove redundant check in MultiWireStructureBuilder #2824

Merged
merged 12 commits into from
Dec 15, 2023
Merged

refactor: Remove redundant check in MultiWireStructureBuilder #2824

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e5742c4
Place the files that create the mockup geometry in another folder
dimitra97 Apr 13, 2023
4a496fc
Change the location of the gdml file
dimitra97 Apr 13, 2023
9939598
updates
Aug 25, 2023
cd9d116
replace cuboid with trapezoid bounds
dimitra97 Nov 9, 2023
ad7bd26
revert file
dimitra97 Nov 9, 2023
756234a
format check
dimitra97 Nov 9, 2023
40185a3
remove lines
dimitra97 Dec 13, 2023
3f12232
revert files
dimitra97 Dec 13, 2023
c48137a
format check
dimitra97 Dec 13, 2023
1f107e2
Delete Core/include/Acts/Navigation/MultiLayerUpdator.hpp
dimitra97 Dec 13, 2023
8ed64cb
Merge branch 'main' into mwbuilder-minor
dimitra97 Dec 15, 2023
3da2d79
Merge branch 'main' into mwbuilder-minor
kodiakhq[bot] Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions Core/src/Detector/MultiWireStructureBuilder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,12 +116,6 @@ Acts::Experimental::MultiWireStructureBuilder::MultiWireStructureBuilder(
Acts::Experimental::DetectorComponent
Acts::Experimental::MultiWireStructureBuilder::construct(
const Acts::GeometryContext& gctx) {
if (mCfg.mlBounds.size() != 4u) {
throw std::invalid_argument(
"MultiWireStructureBuilder: Invalid dimension for bounds. Trapezoid "
"Volume Bounds are supported.");
}

// Configure the external structure builder for the internal structure
Acts::Experimental::VolumeStructureBuilder::Config vsConfig;
vsConfig.boundsType = Acts::VolumeBounds::eTrapezoid;
Expand Down
Loading