[SDK-274] Fix open notification #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Notification Open Action not working on iOS 13 when App is running in the background and the notification is opened from locked screen.
Implementation
Remove the
UIApplicationStatecheck.Add
isDuplicateNotification:userInfocheck. This prevents showing in-app confirm message for the Push (the one we show when a notification arrives while the app is in foreground) when it was opened.This was side effect from step 1. The notification open action was executed correctly but when returning to the app, this confirm was also shown.
Testing steps
Manual Testing on iOS 14 and iOS 13 using Rondo iOS.
Is this change backwards-compatible?
Yes