Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not overwrite the riscv to local copy #17

Closed
wants to merge 1 commit into from

Conversation

myrfy001
Copy link
Contributor

@myrfy001 myrfy001 commented Jul 3, 2022

It seems that there is no need to overwrite riscv crate from online to local version. The local version of riscv will lead to compile error while doing make test2

It seems that there is no need to overwrite riscv crate from online to local version.  The local version of riscv will lead to compile error while doing `make test2`
@chyyuu
Copy link
Member

chyyuu commented Jul 9, 2022

Thank you! But in our envrionment, "make test2" passed.

@Andre-HJR
Copy link

😄 觉得没有必要删除ci中的overwirte.py中的这些

lines = []		
with open("../os/Cargo.toml", 'r') as f:		
    for line in f.readlines():		
        processed = line.replace(' git = "https://github.com/rcore-os/riscv"', ' path = "../ci-user/riscv" ')		
        lines.append(processed)		
with open("../os/Cargo.toml", 'w+') as f:		
    f.writelines(lines)

如果是为了获得更好的本地环境的测试体验,可以考虑将github的源换成gitee的源,

就像这样

lines = []		
with open("../os/Cargo.toml", 'r') as f:		
    for line in f.readlines():		
        processed = line.replace(' git = "https://gitee.com/rcore-os/riscv"', ' path = "../ci-user/riscv" ')		
        lines.append(processed)		
with open("../os/Cargo.toml", 'w+') as f:		
    f.writelines(lines)

test2的代码我就是这么尝试通过的。

@myrfy001
Copy link
Contributor Author

@Andre-HJR

现在的问题是,../ci-user/riscv这个目录下的内容本身就会导致编译失败。(至少在codespace的环境下是这样的)

@chyyuu
Copy link
Member

chyyuu commented Jul 14, 2022

上述信息的解决方案已经在最新的PR中被合并了。谢谢!

@chyyuu chyyuu closed this Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants