-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several updates #19
Several updates #19
Conversation
Support nanos plus device
Add testcases
the denom maxsize also matches the cosmos-sdk coin validations
…c-denoms Increase coin denom maxsize in order to support transactions with IBC tokens
This change fixes a bug in which "num_items 1\n" was unconditionally and incorrectly being logged even when in expert mode, for which the value was changed to 2; this incorrect condition would emit 2 different logs with different values. Fixes #59
Increase coin denom max size
app/src: properly log num_items value for addr_getNumItems
Minor fix for log information
Add idle verification
Updates
Thank you! Looking forward to Ledger team finalizing the security audit. My tokens are blocked far too long time by this bug already ... |
@ftheirs - I am in contact with Ledger support. They wrote: "The Cosmos team should make this PR on the official Cosmos app repo instead of Ledger. We'll gladly merge the changes if the ICF accepts them." Don't know, if this speeds up things, but would be glad, if it did. My token are stuck since quite some time now ... |
Cosmos v2.34.6 is now available in Ledger Live manager. |
Great, everything works fine for me now. Thanks a lot! |
Improve testcases adding extra fields
Increase COIN_DENOM_MAXSIZE in order to solve IBC tokens issue
Remove zxlib source files and configure it as submodule
Add some verifications when the device is locked and verify return error codes
Update to latest Zemu version
Support for NanoS+ is included but that was already merge in develop branch