Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to the new SDK, UX updates, bugfixes #11

Open
wants to merge 119 commits into
base: develop
Choose a base branch
from
Open

Update to the new SDK, UX updates, bugfixes #11

wants to merge 119 commits into from

Conversation

ypopovych
Copy link

@ypopovych ypopovych commented Jun 10, 2024 •
edited
Loading

Checklist

  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped

lpascal-ledger and others added 30 commits January 9, 2023 14:54
@lpascal-ledger
Merge pull request #8 from LedgerHQ/develop
dcc98b6 
Release 0.0.3
@xchapron-ledger
Merge pull request #9 from LedgerHQ/xch/remove-relative-glyph-include
cace191 
src: Update glyphs.h includes so that they don't use relatives includes
@ypopovych
full base58 address. copyright fix
a450a34
@ypopovych
fixed build for new SDK
115e2ae
@ypopovych
moved to the new SDK
a7d428b
@ypopovych
clang format
ec0b833
@ypopovych
fixed variable name
5a1d4c3
@ypopovych
clang format c files
3c22935
@ypopovych
fixed misspeling
bafd0c1
@ypopovych
fix for CI
eb50e06
@ypopovych
config fixes
74a6dff
@ypopovych
fixed crash in rwbuffer
c00229c
@ypopovych
fixed buffer bytes read. fixed hex id length
b0ec4f4
@ypopovych
fixed ERG formatting
0965345
@ypopovych
codestyle fix
28ebcfc
@ypopovych
canary and debug defines
82c24ad
@ypopovych
small fix
b9278a9
@ypopovych
switched to the new blake2 call
d784e5a
@ypopovych
better types for crypto helper
95c214d
@ypopovych
fixed linter error
47d236c
@ypopovych
added changes for issue #11
d5abacf
@ypopovych
code format fixes
52d8ff4
@ypopovych
code linter fix
9938268
@ypopovych
linter fix
b29403e
@ypopovych
CI action versions update
3e405dc
@ypopovych
better bip32 path compare
b85f9e1
@ypopovych
linter fix
2a2d073
@ypopovych
fixed unit tests
983bd7c
@ypopovych
linter fix
9b55a09
@ypopovych
added account check. fixed ui tests
6c0508c
tdejoigny-ledger
tdejoigny-ledger reviewed Nov 4, 2024
View reviewed changes
.github/workflows/ci-workflow.yml Outdated
Comment on lines 7 to 10
name: Build application for NanoS+, X, Stax, Flex
runs-on: ubuntu-latest
strategy:
matrix:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you should have at least this mandatory build CI
https://github.com/LedgerHQ/app-boilerplate/blob/9d8c0f551c5b5c49173c352f542f1f54f187619a/.github/workflows/build_and_functional_tests.yml#L31

@arobsn arobsn mentioned this pull request Nov 4, 2024
Merged
arobsn and others added 13 commits November 4, 2024 12:08
@arobsn
Merge pull request #20 from ergoplatform/build-ci
75a4614 
Update build CI job
@steel97
Rename Token Value > Raw Value
021c4c8
@steel97
Home page standard wording
59c251c
@steel97
Verify address standard template
5c613f6
@steel97
Fix test
014a144
@steel97
Sign transaction ui/ux changes:
5fcc4fc 
- removed Transaction Amount
- renamed P2PK Signing > Start Signing
- renamed Address > To
- renamed Output Value > Amount
- renamed Transaction Fee > Fee
- (stax/flex) renamed Approve Signing > Sign transaction
- (nano s+/x) sign transcation: changed Approve > Sign transaction
@steel97
Change streaming API to nbgl_useCaseReview
f8c6d67
@steel97
Simplify stx ux flow for nanox/s+
8b44029
@steel97
Rewrite test to support simplified stx ux flow
18a47c4
@steel97
Minor ui improvements for stax/flex
0fc8136
@arobsn
Merge pull request #26 from steel97/ui-improvements
3bb9135 
UI improvements
@arobsn
Rename Export Ergo public key to Export Extended Public Key
6ff9a81
@arobsn
Merge pull request #27 from ergoplatform/rename-export-expub
aa699c0 
Rename `Export Ergo public key` to `Export Extended Public Key`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdejoigny-ledger tdejoigny-ledger tdejoigny-ledger left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ypopovych @tdejoigny-ledger @lpascal-ledger @xchapron-ledger @steel97 @kushti @arobsn