Poc detox #2484

valpinkman · 2022-05-04T15:49:33Z

copy of #2211

commit 9cbd84e Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Wed May 4 10:29:58 2022 +0200 changed to text commit ed7e441 Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Tue May 3 17:53:55 2022 +0200 fix node step issue commit 20366c4 Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Tue May 3 17:46:08 2022 +0200 further yarn cache changes commit 0dc6d71 Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Tue May 3 17:29:38 2022 +0200 making review changes - mostly removing console logs, tidying up comments and fixing workflow issues commit 0b92a27 Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Tue May 3 16:39:23 2022 +0200 added cron job and merging from develop commit fcfa9ab Merge: 0092b61 2c9c363 Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Tue May 3 16:38:39 2022 +0200 Merge branch 'develop' of github.com:LedgerHQ/ledger-live-mobile into poc-detox commit 0092b61 Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Tue May 3 13:53:58 2022 +0200 merging and reverting confirmation changes commit 2883d22 Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Tue May 3 13:39:45 2022 +0200 more refactoring commit 18678f8 Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Tue May 3 12:23:59 2022 +0200 removed some shite commit af2df7b Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Tue May 3 10:41:41 2022 +0200 running iOS only in preparation for merge commit 9af839e Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Mon May 2 20:23:59 2022 +0200 Trigger Build commit dd90e9c Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Mon May 2 18:56:33 2022 +0200 added some sleeps to see if that helps commit 4137e7c Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Mon May 2 17:27:04 2022 +0200 fixed wrong config name commit 9964d83 Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Mon May 2 16:42:52 2022 +0200 trying with android staging ci commit f0432ad Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Mon May 2 15:24:18 2022 +0200 Trigger Build commit 480d9fc Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Mon May 2 13:40:47 2022 +0200 removing android tests commit 3f24cff Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Sun May 1 22:00:37 2022 +0200 trying with android debug commit 762a5da Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Sun May 1 20:05:29 2022 +0200 fixing path to bridge for tests commit 7ff8a54 Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Fri Apr 29 19:24:27 2022 +0200 trying bridge in tests themselves commit 5ed8b18 Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Fri Apr 29 16:16:06 2022 +0200 adding flags to test commit 1f0af63 Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Fri Apr 29 13:17:07 2022 +0200 adding lots more screenshots and videos commit 19dd63a Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Fri Apr 29 11:27:05 2022 +0200 adding screenshots and test butler commit a7ef3c6 Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Fri Apr 29 10:03:16 2022 +0200 fixing method name and making both tests run on android commit 89dd701 Merge: 7f43f75 d178dce Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Fri Apr 29 09:10:53 2022 +0200 Merge branch 'poc-detox' of github.com:LedgerHQ/ledger-live-mobile into poc-detox commit 7f43f75 Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Fri Apr 29 09:09:33 2022 +0200 lowering timeout for android commit 03d2584 Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Fri Apr 29 09:08:27 2022 +0200 removed comments, fixed password test and changed onboarding matcher to text instead of testID commit d178dce Author: Nabil Bourenane <nabil.bourenane@icloud.com> Date: Thu Apr 28 18:50:00 2022 +0200 removed forced timezone on device and keep hermes 0.10.0 for now commit d55f1a2 Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Thu Apr 28 18:22:30 2022 +0200 removed setprop commit c9aa1a2 Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Thu Apr 28 18:10:21 2022 +0200 adding second test and changed logs to verbose commit d121087 Merge: 743d332 424ea26 Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Thu Apr 28 18:09:05 2022 +0200 Merge branch 'poc-detox' of github.com:LedgerHQ/ledger-live-mobile into poc-detox commit 424ea26 Author: Nabil Bourenane <nabil.bourenane@icloud.com> Date: Thu Apr 28 17:16:30 2022 +0200 upgrading hermes-engine to 0.10.0 commit 743d332 Merge: 1f40ece 94464ca Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Thu Apr 28 16:56:37 2022 +0200 Merge branch 'poc-detox' of github.com:LedgerHQ/ledger-live-mobile into poc-detox commit 1f40ece Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Thu Apr 28 16:53:13 2022 +0200 adding UTC timezone commit 94464ca Author: Nabil Bourenane <nabil.bourenane@icloud.com> Date: Thu Apr 28 16:07:25 2022 +0200 set timezone on android commit 13bcadd Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Thu Apr 28 15:44:29 2022 +0200 add locale try catch commit ae85cd1 Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Thu Apr 28 14:50:36 2022 +0200 adding logging to timezone and setting timezone to Europe/Paris commit 8f8ef3c Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Thu Apr 28 11:18:24 2022 +0200 updated podfile commit b85a5d5 Merge: 4ce4a81 d2e1742 Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Thu Apr 28 10:07:19 2022 +0200 Merge branch 'develop' of github.com:LedgerHQ/ledger-live-mobile into poc-detox commit 4ce4a81 Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Wed Apr 27 18:18:38 2022 +0200 added detox recorder and android/ios specific matchers since testIDs were unavailable commit 612eeb8 Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Wed Apr 27 16:23:22 2022 +0200 added settings testIds commit 77f2366 Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Tue Apr 26 17:27:09 2022 +0200 trying to run just one test commit 8a7634f Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Tue Apr 26 09:42:17 2022 +0200 adding trace logging and reinstalling app before test run commit 00fb90e Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Mon Apr 25 17:44:35 2022 +0200 increasing ram size commit 17026e0 Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Mon Apr 25 17:03:31 2022 +0200 changed method names commit 5220b3a Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Mon Apr 25 15:52:27 2022 +0200 onboarding test should be working commit 0bd1451 Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Mon Apr 25 12:05:45 2022 +0200 added some new steps to onboarding commit 4d6fc44 Merge: 70370d8 6477c77 Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Fri Apr 22 15:57:01 2022 +0200 Merge branch 'develop' of github.com:LedgerHQ/ledger-live-mobile into poc-detox commit 70370d8 Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Thu Apr 21 15:50:20 2022 +0200 added git config to detox java file commit ad7b25b Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Wed Apr 20 17:17:11 2022 +0200 relogging android goings-on commit 68b5faf Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Tue Apr 19 17:04:27 2022 +0200 fixing artifacts path commit 8b9a386 Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Tue Apr 19 14:17:21 2022 +0200 removing logging in server commit b3d3bb5 Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Tue Apr 19 12:07:38 2022 +0200 fixing comment commit ce7d938 Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Tue Apr 19 09:54:50 2022 +0200 adding screenshots back in commit 2605094 Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Fri Apr 15 16:29:56 2022 +0200 changing to staging commit 2b7971c Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Fri Apr 15 16:19:40 2022 +0200 removed force avd install commit 9213b75 Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Fri Apr 15 14:34:28 2022 +0200 adding console.logs commit 861001a Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Fri Apr 15 10:30:58 2022 +0200 adding yarn start commit 9b6b5ef Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Thu Apr 14 16:43:28 2022 +0200 removing test butler and adding device object to test setup commit c8029db Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Thu Apr 14 15:46:47 2022 +0200 downgrading to API 29 commit 0327446 Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Thu Apr 14 14:35:34 2022 +0200 changing emulator device commit bc20103 Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Thu Apr 14 13:18:58 2022 +0200 fixing engine bugs commit ef8ee12 Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Thu Apr 14 11:58:00 2022 +0200 adding in files that were removed in the rebase commit f7444ec Author: Gregor Gilchrist <gregor.gilchrist@ledger.fr> Date: Tue Mar 29 15:44:43 2022 +0200 more cache fuckery Squashing and rebasing

src/screens/Onboarding/steps/setupDevice/scenes/PairNew.tsx

juan-cortes

Few remarks, nothing blocking a merge for me

juan-cortes · 2022-05-05T10:18:08Z

e2e/models/onboarding/onboardingSteps.js

+  }
+
+  static async startOnboarding() {
+    await testHelpers.tapByText("Get started");


Won't all these break if we change any of the wordings? Why not rely on ids like on other pages? 🤔

I would say that test-ids are useful but don't test in the way the user would, some more infos: https://testing-library.com/docs/queries/about/#priority

juan-cortes · 2022-05-05T10:21:53Z

e2e/specs/password.spec.js

+    await GeneralSettingsPage.enterNewPassword(CORRECT_PASSWORD);
+    await GeneralSettingsPage.enterNewPassword(CORRECT_PASSWORD); // confirm password step
+    await device.sendToHome(); // leave LLM app and go to phone's home screen
+    await delay(60001); // password takes 60 seconds of app inactivity to activate


You could override https://github.com/LedgerHQ/ledger-live-mobile/blob/develop/src/constants.js#L21 if in a test run to not have to wait I guess.

valpinkman requested a review from a team May 4, 2022 15:49

valpinkman requested review from a team as code owners May 4, 2022 15:49

ggilchrist-ledger added 4 commits May 4, 2022 17:50

updated flaky Let's pair nano step

f855d2f

changed to lets pair my nano to tapByText

7cc2c54

fixed linting and yarn issues

db5047b

valpinkman force-pushed the poc-detox branch from 2d8ad90 to db5047b Compare May 4, 2022 15:50

ggilchrist-ledger and others added 6 commits May 4, 2022 17:55

fixed linting and yarn issues

7444b32

removed detox recorder and jcenter

d00e4a1

chore: bump react-native-hid and patch react-native-videos

101f177

use patch to make it usable with pnpm/monorepo

e48e09a

chore: deduplicate issue

8d3420f

juan-cortes reviewed May 5, 2022

View reviewed changes

src/screens/Onboarding/steps/setupDevice/scenes/PairNew.tsx Outdated Show resolved Hide resolved

juan-cortes approved these changes May 5, 2022

View reviewed changes

chore: fix id

bde15e7

valpinkman added the feature-ready label May 5, 2022

lambertkevin changed the base branch from develop to release/3.1.x May 5, 2022 13:29

valpinkman merged commit 9fba0c2 into release/3.1.x May 5, 2022

valpinkman deleted the poc-detox branch May 5, 2022 13:30

This was referenced May 5, 2022

release/3.1.x #2486

Merged

Release/3.1.x #2505

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Poc detox #2484

Poc detox #2484

valpinkman commented May 4, 2022 •

edited

Loading

juan-cortes left a comment

juan-cortes May 5, 2022

Justkant May 5, 2022

juan-cortes May 5, 2022

Poc detox #2484

Poc detox #2484

Conversation

valpinkman commented May 4, 2022 • edited Loading

juan-cortes left a comment

Choose a reason for hiding this comment

juan-cortes May 5, 2022

Choose a reason for hiding this comment

Justkant May 5, 2022

Choose a reason for hiding this comment

juan-cortes May 5, 2022

Choose a reason for hiding this comment

valpinkman commented May 4, 2022 •

edited

Loading