This repository has been archived by the owner on Jun 27, 2022. It is now read-only.
Cleanup babel config #247
Merged
Cleanup babel config #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gre
approved these changes
Nov 20, 2018
|
Is there anything blocking this from being merged? Right now, babel-runtime is obsolete. If you decide to revert #228, you need
In any case, this cleanup makes sense I think. |
|
nothing is blocking but time for the team to test this. i'll take a look as soon as I have more time 🤞 |
gre
approved these changes
Jan 18, 2019
KhalilBellakrid
pushed a commit
to KhalilBellakrid/ledgerjs
that referenced
this pull request
Jan 24, 2019
Cleanup babel config
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I verified that there is no
require("babel-runtime)in the libs/ output anymore,thus closes #211but all packages need a rebuild