Fixed missing 'babel-polyfill' dependency #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @rob234 |
webmaster128
reviewed
Jan 3, 2019
| @@ -40,6 +40,7 @@ | |||
| "@angular/router": "^5.0.0", | |||
| "@ledgerhq/hw-transport-u2f": "^4.7.3", | |||
| "@types/crypto-js": "^3.1.38", | |||
| "babel-polyfill": "^6.26.0", | |||
There was a problem hiding this comment.
This dependency of the monorepo root package.json will not be a dependency of the published npm packages. In fact, this section behaves like devDependencies (see LedgerHQ/ledgerjs#247)
There was a problem hiding this comment.
Sorry about the comment above, I was in the wrong repository
|
Thanks for finding this @rob234 - sorry for the delay but I am merging it in now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems something changed in the node.js default setup in ubuntu 18.04 and fresh installations of nanovault do not work anymore. After adding the 'babel-polyfill' dependency everything is fine again.