-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta-issue to track cross-compiling progress #575
Comments
The So we need to modify
I guess this should go into |
Making our desired changes the default behavior (rather than optional features) of |
oh okay good to know. should i change the api of i could change the
would that be helpful? if so, here's a branch for that functionality: https://github.com/ahdinosaur/prebuildify-cross/tree/prebuildify-args 🌟 (by the way, i will be away from my computer for next 5 days, off to party in the bush 🏞️ ☀️ 💃 🎶 ) |
@vweevers At first I was wondering why we shouldn't do this, but I guess it doesn't make any sense to do this for e.g.
@ahdinosaur Yes, I think this would be helpful, since we need to have different behavior for |
Status update: it has taken quite a few iterations (of PRs, test releases and discussions), but I think we finally have a complete plan now. Note that some of the discussion above is outdated as we decided to replace I've opened prebuild/prebuildify#26 which consolidates recent ad-hoc changes (for overriding strip, platform, arch) into a clean and documented set of options. Once that is merged, we'll have to update the Docker images accordingly. Then we can implement the new naming scheme for prebuilds (prebuild/prebuildify#25), on which the discussion has now settled as well. The only thing that's unclear to me is Android support. Specifically, whether to use and target the |
@vweevers |
Would it be an option to use node core for Android, and
|
Thanks to this tweet I learned it's because iOS disallows write-access to executable memory. V8 7.4 addresses this by introducing a interpreter-only mode. Some time in the future node core should be able to take advantage of that! cc @mcollina Does node have any official plans yet? |
As this effort spans multiple projects (both in tooling and target audience). In mostly chronological order:
prebuildify
strip
command (PR: allow overriding strip command for cross-compilation prebuild/prebuildify#19)platform
([wip] Allow overriding target platform when cross-compiling prebuild/prebuildify#22)(PR: Cleanup options prebuild/prebuildify#26)node-gyp-build
using docker directlyprebuildify-cross
: feature complete? TBDdocker-images
(PR: Update prebuild/docker-images#5)leveldown
prebuildify-cross
: (PR:[wip] cross-compile prebuilds #572Cross compile armv7 (for RPI) #584)--tag-armv
flag inscripts/cross-compile
(this ensures that e.g. armv6 machines don't select the armv7 prebuild)npx prebuildify -t 8.14.0 --napi --strip
withnpm run prebuild
(now equal)-t electron@3.0.0
toprebuildify
when cross-compilingFeel free to edit if I missed anything.
cc @ralphtheninja @ahdinosaur @staltz @mafintosh
The text was updated successfully, but these errors were encountered: