-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] Allow overriding target platform when cross-compiling #22
Conversation
No need to release new version once merged. |
2af1bae
to
1125e68
Compare
@ahdinosaur I reverted your changes and now I'm only modifying the initial Line 33 in 1125e68
And we do not care about it in e.g. Line 109 in 1125e68
nor here: Line 138 in 1125e68
The last two cases should always use Makes sense? We might need to distinguish this in the code though for less confusion. |
Setting wip status once again. Need to test and play around with this for a while. |
1125e68
to
def1396
Compare
Maybe rename |
At first I thought yes, but we're doing |
Wouldn't #25 mean a semver-major anyway? If not, we could also do: opts = xtend({
arch: process.env.ARCH || os.arch(),
targetPlatform: opts.platform || process.env.TARGET_PLATFORM || os.platform(),
cwd: '.',
targets: []
}, opts) |
Yeah that's true! |
def1396
to
f14c7ed
Compare
Travis borked for Windows 10. Restarting build. |
Sorry for the turnaround, but I just noticed Lines 37 to 39 in 8529e6d
Which implies |
😆 Agreed. I'd like to keep it as |
👍 (I meant that for now it'd be better to revert renaming |
Aaah ok. Sure! |
This reverts commit f14c7ed.
hi everyone, sorry i've been away at a festival for over a week, thanks for reaching out @ralphtheninja. 😺 i agree the so to loop back my understanding:
❤️ |
A first stab at documenting this:
There's no easy (non-breaking) way to clean this up, but now would be the time. Knowing that:
I propose (changes bold) (I'm not sure what to do with strip args):
|
@vweevers looks really good and I agree with your prefix. For simplicity/completeness I would name strip simply PREBUILD_STRIP with same semantics as above. Then there is no special case for that one |
Do we support setting strip args from the outside? |
Table updated.
We could start with |
I'll open a new PR (but please keep this |
Supersedes #20