Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] Allow overriding target platform when cross-compiling #22

Closed
wants to merge 4 commits into from
Closed

[wip] Allow overriding target platform when cross-compiling #22

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3add455
Allow overriding platform for cross-compiling
ralphtheninja Jan 22, 2019
f14c7ed
opts.platform -> opts.targetPlatform
ralphtheninja Jan 25, 2019
8529e6d
Use os.platform() in strip()
ralphtheninja Jan 25, 2019
7ac8365
Revert "opts.platform -> opts.targetPlatform"
ralphtheninja Jan 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,10 +171,11 @@ function findBuild (dir, cb) {
}

function strip (file, opts, cb) {
if (!opts.strip || (opts.platform !== 'darwin' && opts.platform !== 'linux')) return cb()
var platform = os.platform()
if (!opts.strip || (platform !== 'darwin' && platform !== 'linux')) return cb()
vweevers marked this conversation as resolved.
Show resolved Hide resolved

var args = opts.platform === 'darwin' ? [file, '-Sx'] : [file, '--strip-all']
var stripBin = process.env.STRIP || 'strip'
var args = platform === 'darwin' ? [file, '-Sx'] : [file, '--strip-all']
var child = proc.spawn(stripBin, args, {stdio: 'ignore'})

child.on('exit', function (code) {
Expand Down