Enable logging hparams only if there are any

[rohitgr7]

What does this PR do?

Partly resolves: #11103

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

• Was this discussed/approved via a GitHub issue? (not for typos and docs)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure your PR does only one thing, instead of bundling different changes together?
• Did you make sure to update the documentation with your changes? (if necessary)
• Did you write any new necessary tests? (not for typos and docs)
• Did you verify new and existing tests pass locally with your changes?
• Did you list all the breaking changes introduced by this pull request?
• Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

• Is this pull request ready for review? (if not, please submit in draft mode)
• Check that all items from Before submitting are resolved
• Make sure the title is self-explanatory and the description concisely explains the PR
• Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @awaelchli @edward-io @Borda @ananthsub

[carmocca]

The changes look good, but I'm wondering if there was a good reason to set True by default. Perhaps for sanity checking? to make sure logging works at all?

Did you try git blaming the addition and see if there was any discussion about it?

[rohitgr7]

The changes look good, but I'm wondering if there was a good reason to set True by default. Perhaps for sanity checking? to make sure logging works at all?

Did you try git blaming the addition and see if there was any discussion about it?

@carmocca it was added here: #7960

doesn't seem to have any discussion regarding this. let me ping @kaushikb11 for review.

[awaelchli]

As far as I can see this is only getting set when calling self.save_hyperparameters() (logger=True by default) so this should be good!