Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logger flag to save_hyperparameters #7960

Merged
merged 15 commits into from
Jul 13, 2021

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Jun 13, 2021

What does this PR do?

Fixes #6338

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jun 13, 2021

Codecov Report

Merging #7960 (3b0a84a) into master (09ff295) will decrease coverage by 5%.
The diff coverage is 95%.

@@           Coverage Diff           @@
##           master   #7960    +/-   ##
=======================================
- Coverage      93%     88%    -5%     
=======================================
  Files         216     216            
  Lines       14009   14109   +100     
=======================================
- Hits        12985   12416   -569     
- Misses       1024    1693   +669     

@kaushikb11 kaushikb11 added the feature Is an improvement or enhancement label Jun 18, 2021
@kaushikb11 kaushikb11 added this to the v1.4 milestone Jun 18, 2021
@kaushikb11 kaushikb11 marked this pull request as ready for review June 18, 2021 04:28
Copy link
Member

@justusschock justusschock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try this with tensorboard? I think we disabled this on purpose, since actually we had issues that if we log them in the beginning, TB (the most common logger and default) does not properly update the metrics.

pytorch_lightning/core/lightning.py Outdated Show resolved Hide resolved
pytorch_lightning/core/lightning.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
tests/loggers/test_base.py Outdated Show resolved Hide resolved
@awaelchli awaelchli added the logging Related to the `LoggerConnector` and `log()` label Jun 18, 2021
@mergify mergify bot removed the has conflicts label Jul 9, 2021
@kaushikb11 kaushikb11 requested a review from ananthsub as a code owner July 9, 2021 15:32
kaushikb11 and others added 2 commits July 9, 2021 21:11
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
@kaushikb11 kaushikb11 changed the title Add log flag to save_hyperparameters Add logger flag to save_hyperparameters Jul 9, 2021
kaushikb11 and others added 2 commits July 12, 2021 14:34
Copy link
Contributor

@SeanNaren SeanNaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice feature!

@kaushikb11 kaushikb11 added the ready PRs ready to be merged label Jul 13, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it !

pytorch_lightning/utilities/hparams_mixin.py Show resolved Hide resolved
@tchaton tchaton merged commit 9d5ad76 into Lightning-AI:master Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement logging Related to the `LoggerConnector` and `log()` ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support save_hyperparameters() to checkpoints without sending to logger
6 participants