-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logger flag to save_hyperparameters #7960
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7960 +/- ##
=======================================
- Coverage 93% 88% -5%
=======================================
Files 216 216
Lines 14009 14109 +100
=======================================
- Hits 12985 12416 -569
- Misses 1024 1693 +669 |
2cd9f7d
to
5c11860
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you try this with tensorboard? I think we disabled this on purpose, since actually we had issues that if we log them in the beginning, TB (the most common logger and default) does not properly update the metrics.
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice feature!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it !
What does this PR do?
Fixes #6338
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃