Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing for trainer.logger #11114

Merged
merged 3 commits into from
Dec 17, 2021
Merged

Add typing for trainer.logger #11114

merged 3 commits into from
Dec 17, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Dec 16, 2021

What does this PR do?

This uncovered a bug with track_grad_norm where it fails with logger=False

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @awaelchli @edward-io @Borda @ananthsub

@carmocca carmocca added logger Related to the Loggers code quality labels Dec 16, 2021
@carmocca carmocca added this to the 1.5.x milestone Dec 16, 2021
@carmocca carmocca self-assigned this Dec 16, 2021
@carmocca carmocca added the bug Something isn't working label Dec 16, 2021
@carmocca carmocca marked this pull request as ready for review December 16, 2021 23:57
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@carmocca carmocca enabled auto-merge (squash) December 17, 2021 02:52
@mergify mergify bot added the ready PRs ready to be merged label Dec 17, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@carmocca carmocca merged commit 4415677 into master Dec 17, 2021
@carmocca carmocca deleted the typing/trainer.logger branch December 17, 2021 12:34
awaelchli added a commit that referenced this pull request Dec 21, 2021
lexierule pushed a commit that referenced this pull request Dec 21, 2021
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code quality logger Related to the Loggers ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants