Allow reinits in sub procs #1149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1149 +/- ##
======================================
- Coverage 93% 92% -0%
======================================
Files 61 61
Lines 2672 2676 +4
======================================
+ Hits 2472 2475 +3
- Misses 200 201 +1 |
Borda
requested changes
Mar 15, 2020
Comment on lines
+66
to
+69
| if self._experiment is not None: | ||
| state['_id'] = self._experiment.id | ||
| else: | ||
| state['_id'] = None |
There was a problem hiding this comment.
Suggested change
| if self._experiment is not None: | |
| state['_id'] = self._experiment.id | |
| else: | |
| state['_id'] = None | |
| state['_id'] = self._experiment.id if self._experiment is not None else None |
Comment on lines
+119
to
+122
| if self._experiment: | ||
| return self._experiment.project_name() | ||
| else: | ||
| return None |
There was a problem hiding this comment.
Suggested change
| if self._experiment: | |
| return self._experiment.project_name() | |
| else: | |
| return None | |
| if self._experiment: | |
| return self._experiment.project_name() | |
| return None |
Comment on lines
+127
to
+130
| if self._experiment: | ||
| return self._experiment.id | ||
| else: | ||
| return None |
There was a problem hiding this comment.
Suggested change
| if self._experiment: | |
| return self._experiment.id | |
| else: | |
| return None | |
| if self._experiment: | |
| return self._experiment.id | |
| return None |
|
@vanpelt thx for you work, could you please check my comments so we can get it done :] |
|
Hey, any update here? |
|
This pull request is now in conflict... :( |
|
@vanpelt mind rebasing? looks like there are conflicts |
|
@vanpelt mind allow edit for maintainers? |
Merged
|
Finished in #1360 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes #981
When using multiprocessing the default behavior of wandb is to return None for multiple calls to init. Passing reinit=True ensure we always create an experiment. This could lead to cases where a single experiment has multiple runs in wandb, but it's a much better default than throwing an exception.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃