Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wandb bug/wandb multi #1360

Merged
merged 5 commits into from
Apr 3, 2020
Merged

Wandb bug/wandb multi #1360

merged 5 commits into from
Apr 3, 2020

Conversation

williamFalcon
Copy link
Contributor

@williamFalcon williamFalcon commented Apr 3, 2020 •
edited by Borda
Loading

Finishes #1149, fixes #981

@mergify mergify bot requested a review from a team April 3, 2020 13:32
@williamFalcon williamFalcon mentioned this pull request Apr 3, 2020
Closed
5 tasks
@Borda Borda added the bug Something isn't working label Apr 3, 2020
@Borda Borda added this to the 0.7.2 milestone Apr 3, 2020
Borda
Borda reviewed Apr 3, 2020
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for test coverage

pytorch_lightning/loggers/wandb.py Outdated Show resolved Hide resolved
pytorch_lightning/loggers/wandb.py Outdated Show resolved Hide resolved
pytorch_lightning/loggers/wandb.py Outdated Show resolved Hide resolved
Borda
Borda approved these changes Apr 3, 2020
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Borda Borda added the ready PRs ready to be merged label Apr 3, 2020
@williamFalcon williamFalcon merged commit 3c5530c into master Apr 3, 2020
@williamFalcon williamFalcon deleted the wandb-bug/wandb-multi branch April 3, 2020 19:11
alexeykarnachev pushed a commit to alexeykarnachev/pytorch-lightning that referenced this pull request Apr 4, 2020
@williamFalcon @vanpelt @Borda
Wandb bug/wandb multi (Lightning-AI#1360)
321d9af 
* Allow reinits in sub procs

* Dont create an experiment on pickle, name, or project

* Comments consistency

* Fix test

* Apply suggestions from code review

Co-authored-by: Chris Van Pelt <vanpelt@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
tullie pushed a commit to tullie/pytorch-lightning that referenced this pull request Jun 7, 2020
@williamFalcon @vanpelt
@Borda @tullie
Wandb bug/wandb multi (Lightning-AI#1360)
63ebf0d 
* Allow reinits in sub procs

* Dont create an experiment on pickle, name, or project

* Comments consistency

* Fix test

* Apply suggestions from code review

Co-authored-by: Chris Van Pelt <vanpelt@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
@Borda Borda modified the milestones: v0.7., v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

Assignees
No one assigned
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Milestone
pl:0.7.x
Development

Successfully merging this pull request may close these issues.

WandbLogger cannot be used with 'ddp'
3 participants
@williamFalcon @Borda @vanpelt