Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Strategy._move_optimizer_states as utility functions #11758

Merged
merged 6 commits into from
Feb 18, 2022
Merged

Refactor Strategy._move_optimizer_states as utility functions #11758

merged 6 commits into from
Feb 18, 2022

Conversation

ananthsub
Copy link
Contributor

@ananthsub ananthsub commented Feb 5, 2022 •
edited
Loading

What does this PR do?

Refactoring to make the code easier to test by splitting this out as a separate function. I didn't see any existing tests for this. This will simplify #11757

Does your PR introduce any breaking changes? If yes, please list them.

Yes, if custom Strategy implementations overrode _move_optimizer_to_device, they will break after this PR

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@ananthsub ananthsub added this to the 1.6 milestone Feb 5, 2022
@ananthsub ananthsub mentioned this pull request Feb 5, 2022
Merged
12 tasks
@awaelchli
Copy link
Contributor

@ananthsub do you think we could unify this with some similar lines of code we have in CheckpointConnector.restore_optimizers?

@ananthsub
Copy link
Contributor Author

ananthsub commented Feb 5, 2022 •
edited
Loading

@ananthsub do you think we could unify this with some similar lines of code we have in CheckpointConnector.restore_optimizers?

Yes exactly. that was my motivation for this PR after seeing the bug here: #11741

See my comment here: #11757 (comment)

@mergify mergify bot added the has conflicts label Feb 7, 2022
@mergify mergify bot removed the has conflicts label Feb 7, 2022
@ananthsub ananthsub added the checkpointing Related to checkpointing label Feb 7, 2022
@mergify mergify bot added the has conflicts label Feb 7, 2022
tchaton
tchaton approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@tchaton tchaton enabled auto-merge (squash) February 14, 2022 09:02
@mergify mergify bot added ready PRs ready to be merged has conflicts and removed has conflicts labels Feb 14, 2022
@mergify mergify bot removed the has conflicts label Feb 18, 2022
@tchaton tchaton merged commit cf64f34 into Lightning-AI:master Feb 18, 2022
carmocca pushed a commit that referenced this pull request Feb 18, 2022
@ananthsub @pre-commit-ci
@tchaton @carmocca
Refactor Strategy._move_optimizer_states as utility functions (#11758)
320d65d 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: thomas chaton <thomas@grid.ai>
@ananthsub ananthsub mentioned this pull request Feb 18, 2022
Closed
@ananthsub ananthsub deleted the feat/refactor-optimizer-move branch February 18, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@carmocca carmocca carmocca approved these changes

@tchaton tchaton tchaton approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@edenlightning edenlightning Awaiting requested review from edenlightning

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees
No one assigned
Labels
checkpointing Related to checkpointing ready PRs ready to be merged refactor strategy
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.
5 participants
@ananthsub @awaelchli @SeanNaren @carmocca @tchaton