-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate Trainer.root_gpu
#11994
Labels
Comments
ananthsub
added
good first issue
Good for newcomers
refactor
deprecation
Includes a deprecation
trainer
labels
Feb 18, 2022
I would like to work on this issue |
hey @vpavankalyan! |
12 tasks
linrock
added a commit
to linrock/nnue-tools
that referenced
this issue
Nov 24, 2022
Attempts to use easy_train.sh crash with this error: AttributeError: `Trainer.root_gpu` was deprecated in v1.6 and is no longer accessible as of v1.8. Please use `Trainer.strategy.root_device.index` instead. Support for Trainer.root_gpu was removed in: Lightning-AI/pytorch-lightning#11994
linrock
added a commit
to linrock/nnue-pytorch
that referenced
this issue
Nov 25, 2022
AttributeError: `Trainer.root_gpu` was deprecated in v1.6 and is no longer accessible as of v1.8. Please use `Trainer.strategy.root_device.index` instead. Support for Trainer.root_gpu was removed in: Lightning-AI/pytorch-lightning#11994
linrock
added a commit
to linrock/nnue-pytorch
that referenced
this issue
Nov 29, 2022
AttributeError: `Trainer.root_gpu` was deprecated in v1.6 and is no longer accessible as of v1.8. Please use `Trainer.strategy.root_device.index` instead. Support for Trainer.root_gpu was removed in: Lightning-AI/pytorch-lightning#11994
linrock
added a commit
to linrock/nnue-pytorch
that referenced
this issue
Dec 1, 2022
AttributeError: `Trainer.root_gpu` was deprecated in v1.6 and is no longer accessible as of v1.8. Please use `Trainer.strategy.root_device.index` instead. Support for Trainer.root_gpu was removed in: Lightning-AI/pytorch-lightning#11994
linrock
added a commit
to linrock/nnue-pytorch
that referenced
this issue
Dec 25, 2022
AttributeError: `Trainer.root_gpu` was deprecated in v1.6 and is no longer accessible as of v1.8. Please use `Trainer.strategy.root_device.index` instead. Support for Trainer.root_gpu was removed in: Lightning-AI/pytorch-lightning#11994
vondele
pushed a commit
to vondele/nnue-pytorch
that referenced
this issue
Jan 1, 2023
AttributeError: `Trainer.root_gpu` was deprecated in v1.6 and is no longer accessible as of v1.8. Please use `Trainer.strategy.root_device.index` instead. Support for Trainer.root_gpu was removed in: Lightning-AI/pytorch-lightning#11994
linrock
added a commit
to linrock/nnue-pytorch
that referenced
this issue
Jan 3, 2023
AttributeError: `Trainer.root_gpu` was deprecated in v1.6 and is no longer accessible as of v1.8. Please use `Trainer.strategy.root_device.index` instead. Support for Trainer.root_gpu was removed in: Lightning-AI/pytorch-lightning#11994
linrock
added a commit
to linrock/nnue-pytorch
that referenced
this issue
Jan 7, 2023
AttributeError: `Trainer.root_gpu` was deprecated in v1.6 and is no longer accessible as of v1.8. Please use `Trainer.strategy.root_device.index` instead. Support for Trainer.root_gpu was removed in: Lightning-AI/pytorch-lightning#11994
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Proposed refactor
Deprecate this property:
https://github.com/PyTorchLightning/pytorch-lightning/blob/cf64f3443474a93d23b5afb0417e4a60298006e6/pytorch_lightning/trainer/trainer.py#L1982-L1984
Motivation
This property is redundant with the Strategy's
root_device
property, which generalizes this check.Following #11758, this property is not used anywhere else in the framework. This is only used in tests, which can be updated to use
trainer.strategy.root_device
insteadPitch
Deprecate this property, and recommend using
trainer.strategy.root_device
insteadRegarding how to deprecate the property, this issue provides an example: #10615
Additional context
If you enjoy Lightning, check out our other projects! ⚡
Metrics: Machine learning metrics for distributed, scalable PyTorch applications.
Lite: enables pure PyTorch users to scale their existing code on any kind of device while retaining full control over their own loops and optimization logic.
Flash: The fastest way to get a Lightning baseline! A collection of tasks for fast prototyping, baselining, fine-tuning, and solving problems with deep learning.
Bolts: Pretrained SOTA Deep Learning models, callbacks, and more for research and production with PyTorch Lightning and PyTorch.
Lightning Transformers: Flexible interface for high-performance research using SOTA Transformers leveraging Pytorch Lightning, Transformers, and Hydra.
cc @Borda @justusschock @awaelchli @rohitgr7 @tchaton @akihironitta @kaushikb11 @ananthsub @ninginthecloud @jjenniferdai
The text was updated successfully, but these errors were encountered: